Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hyperlink: urls in pdf #228

Merged
merged 3 commits into from
Jan 21, 2024
Merged

fix: hyperlink: urls in pdf #228

merged 3 commits into from
Jan 21, 2024

Conversation

ngmgit
Copy link

@ngmgit ngmgit commented Jan 21, 2024

URL's were not clickable due to missing href latex package import and tags.

@ngmgit
Copy link
Author

ngmgit commented Jan 21, 2024

I made the changes for other templates, but couldnt figure out why the templates 4 and 7 dont work with these changes.

@ducaale
Copy link
Collaborator

ducaale commented Jan 21, 2024

Thanks @ngmgit.

Do you have an example of an unclickable link? I'm trying to reproduce the issue you saw locally.

@ngmgit
Copy link
Author

ngmgit commented Jan 21, 2024

simplescreenrecorder-2024-01-21_20.09.08.mp4

@ducaale
Added a project and its url but when I generate the pdf the link is not clickable, please check the video. And for the website url section, i.e rendered at top, you have to use a json from older v2 version deployed at https://latexresu.me/

Copy link
Collaborator

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can address the template 4 & 7 project links in a follow-up PR.

@ducaale ducaale merged commit 0274664 into saadq:main Jan 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants