Drop uuid and just use native mkdtemp
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
uuid and just use native mktempuuid and just use native mkdtemp
fregante
commented
Mar 10, 2021
| @@ -603,7 +602,7 @@ FirefoxProfile.prototype._installExtension = function (addon, cb) { | |||
| self = this; | |||
|
|
|||
| if (addon.slice(-4) === '.xpi') { | |||
| tmpDir = this._createTempFolder(addon.split(path.sep).slice(-1)); | |||
| tmpDir = this._createTempFolder(addon.split(path.sep).pop()); | |||
There was a problem hiding this comment.
slice returned an array. It worked before because _createTempFolder was concatenating this with +
| @@ -152,7 +151,7 @@ function FirefoxProfile(options) { | |||
| this.profileDir = opts.destinationDirectory || this._createTempFolder(); | |||
| } else { | |||
| // create copy | |||
| var tmpDir = opts.destinationDirectory || this._createTempFolder('-copy'); | |||
| var tmpDir = opts.destinationDirectory || this._createTempFolder('copy-'); | |||
There was a problem hiding this comment.
I had to change this to be a prefix instead of suffix due to how the API works.
This path is meant to be temporary and hidden from the user, so I'm guessing it was implemented only to improve debugging but isn't fundamental.
There was a problem hiding this comment.
The idea here is to not alter an existing profile directory (if provided in options.profileDir).
|
@fregante I released v4.2.0 earlier today 🎉 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node has had a way to create temporary directories since v5: https://nodejs.org/api/fs.html#fs_fs_mkdtempsync_prefix_options
Sorry for the noise in this PR. It took me a while to figure out why it was refusing to work on Travis