Fix/profile finder cb without return #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadtazi
force-pushed
the
fix/profile-finder-cb-without-return
branch
from
62135a8 to
b5837cf
Compare
saadtazi
commented
Sep 28, 2023
| function (err, data) { | ||
| if (err) { | ||
| cb(err); | ||
| return; |
There was a problem hiding this comment.
the only change, the rest is prettier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported in this github issue: in profile_finder, we were invoking the callback function when an error occured but were not returning immediately.