Fix docker export v1 problem #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medamineziraoui
changed the title
ZouhairBear
reviewed
Sep 3, 2020
src/main/groovy/io/saagie/plugin/dataops/tasks/service/TechnologyService.groovy
Show resolved
Hide resolved
src/main/groovy/io/saagie/plugin/dataops/tasks/service/TechnologyService.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/io/saagie/plugin/dataops/tasks/service/TechnologyService.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/io/saagie/plugin/dataops/tasks/service/TechnologyService.groovy
Outdated
Show resolved
Hide resolved
DecampsRenan
suggested changes
Sep 3, 2020
| @@ -1488,7 +1488,7 @@ class SaagieClient { | |||
| } | |||
| def listVariables = getListOfVariablesFromRequest(variablesListRequest) | |||
| if (listVariables.size().equals(0)) { | |||
| println "WARNING: No environment variable found on the targeted platform with scope ${configuration.env.scope}" | |||
| system.out.println "WARNING: No environment variable found on the targeted platform with scope ${configuration.env.scope}" | |||
There was a problem hiding this comment.
Please use logger.warn or something like that instead of basic sop :)
| @@ -1558,7 +1558,7 @@ class SaagieClient { | |||
|
|
|||
| listVariables = getAllVariablesFromV1() | |||
| if (listVariables.size().equals(0)) { | |||
| println "WARNING: No environment variable found on the targeted platform with scope ${configuration.env.scope}" | |||
| system.out.println "WARNING: No environment variable found on the targeted platform with scope ${configuration.env.scope}" | |||
src/main/groovy/io/saagie/plugin/dataops/tasks/service/TechnologyService.groovy
Show resolved
Hide resolved
| } | ||
| def numberVersionExtraTechnologyV2 = getUntilFind(extraTechnologyV2["versions"], null, extraVersionNumberV1) | ||
| if (!numberVersionExtraTechnologyV2) { | ||
| throwAndLogError("Couldn t get number version for extra technology") |
There was a problem hiding this comment.
Suggested change
| throwAndLogError("Couldn t get number version for extra technology") | |
| throwAndLogError("Couldn't get number version for extra technology") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#314