Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read dimension_separator from .zarray #6

Closed
bogovicj opened this issue Sep 8, 2021 · 2 comments
Closed

read dimension_separator from .zarray #6

bogovicj opened this issue Sep 8, 2021 · 2 comments

Comments

@bogovicj
Copy link
Collaborator

bogovicj commented Sep 8, 2021 •
edited
Loading

The current implementation does not read from the (more n5-like) zarr NestedDirectoryStore.

The above is wrong - such data can be read, but one needs to know the dimension_separator at the time of constructing the N5ZarrReader. New zarr versions tell you in .zarray, see below:
@bogovicj
Copy link
Collaborator Author

bogovicj commented Sep 8, 2021

See:
zarr-developers/zarr-python#530
and
zarr-developers/zarr-python#716

@bogovicj bogovicj changed the title Support NestedDirectoryStore read dimension_separator from .zarray Sep 8, 2021
bogovicj added a commit to bogovicj/n5-zarr that referenced this issue Sep 8, 2021
@bogovicj
feat: detect dimension_separator from .zarray
60c148e 
* write dimension_separator to .zarray
* add tests

see saalfeldlab#6
@bogovicj bogovicj mentioned this issue Sep 8, 2021
Merged
@bogovicj
Copy link
Collaborator Author

bogovicj commented Dec 7, 2021

this feature was added by #7

@bogovicj bogovicj closed this as completed Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bogovicj