Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logtunnel #1

Merged
merged 7 commits into from
Jan 18, 2018
Merged

Logtunnel #1

merged 7 commits into from
Jan 18, 2018

Conversation

sabban
Copy link
Owner

@sabban sabban commented Jan 18, 2018

Add tunnel feature.

  • This would close features discussions moul/sshportal#23
  • This add tunnel feature.
  • A slightly light issue with the select "loop" in bastionsession. This is solved by calling the whole ChannelHandler in a goroutiner in order multiple Channel be handled at the same time.
  • Initially I gave a try to log tunnel with pcap format. But this can only be done by creating a custom network protocol or create a false tcp session (creating ACK, SYN+ACK packets from nothing, and put payload with PSH). So I tweaked a little the ttyrec format with name of host after the date, to see it with ttyplay. At least this allow ttyplay to replay session, and we are able to see session when they are human readable.
  • I created a new pkg logtunnel after logchannel. I choose to create a new pkg, because I believe that our file format for logtunnel can evolve to a better thing, and this way this can be handled separately from the channel.

Manuel Sabban and others added 7 commits January 16, 2018 15:56
bastionsession.go, and we couldn't open a new channel. The fix is
easy it calls the bastionsession.ChannelHandler in a goroutine,
at the cost of some error management. I think this is ok because
we can allow a channel to fail on his own. This seems to be
* This add the tunnel feature, which use a new concurrent channel.
* This add some pcap logging for tunnel.
For now it is logged only one way, and the logged ip packet seems
buggy.
The logfile format is a tweaked version of ttyrec foramt file as it will be easy to review the use of human readable tunnel...
@sabban sabban merged commit 2c3de75 into tunnel Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants