TASK: Fix non idempotent rector (#3441)

* TASK: Fix idempotent rector Resolves: #3234 * [ci-review] Rector Rectify --------- Co-authored-by: GitHub Action <action@github.com>
sabbelasichon · Jul 31, 2023 · 2cade62 · 2cade62
1 parent f1118d9
commit 2cade62
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/Rector/v12/v0/typo3/AbstractMessageGetSeverityRector.php b/src/Rector/v12/v0/typo3/AbstractMessageGetSeverityRector.php
@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Identifier;
 use PHPStan\Type\ObjectType;
 use Rector\Core\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -38,6 +39,12 @@ public function refactor(Node $node)
             return null;
         }
 
+        $nextNode = $this->betterNodeFinder->resolveNextNode($node);
+
+        if ($nextNode instanceof Identifier && $this->isName($nextNode, 'value')) {
+            return null;
+        }
+
         return $this->nodeFactory->createPropertyFetch($node, 'value');
     }
 

diff --git a/tests/Rector/v12/v0/typo3/AbstractMessageGetSeverityRector/Fixture/FlashMessage.php.inc b/tests/Rector/v12/v0/typo3/AbstractMessageGetSeverityRector/Fixture/FlashMessage.php.inc
@@ -6,6 +6,7 @@ use \TYPO3\CMS\Core\Messaging\FlashMessage;
 
 $flashMessage = new FlashMessage('This is a message');
 $severityAsInt = $flashMessage->getSeverity();
+$severityValue = $flashMessage->getSeverity()->value;
 ?>
 -----
 <?php
@@ -16,4 +17,5 @@ use \TYPO3\CMS\Core\Messaging\FlashMessage;
 
 $flashMessage = new FlashMessage('This is a message');
 $severityAsInt = $flashMessage->getSeverity()->value;
+$severityValue = $flashMessage->getSeverity()->value;
 ?>