[BUGFIX] Use arg as var name instead of fixed one

Resolves: #3940
sabbelasichon · Dec 22, 2023 · 3d7c016 · 3d7c016
1 parent 9b3fdfe
commit 3d7c016
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Rector/v11/v3/SubstituteMethodRmFromListOfGeneralUtilityRector.php b/src/Rector/v11/v3/SubstituteMethodRmFromListOfGeneralUtilityRector.php
@@ -59,8 +59,9 @@ public function refactor(Node $node): ?Node
         $explodeFuncCall = $this->nodeFactory->createFuncCall('explode', [',', $node->args[1]]);
 
         $itemVariable = new Variable('item');
+        $elementVariable = new Variable($this->nodeNameResolver->getName($node->args[0]->value));
 
-        $stmts = [new Return_(new Equal(new Variable('element'), $itemVariable))];
+        $stmts = [new Return_(new Equal($elementVariable, $itemVariable))];
 
         $closureFunction = $this->anonymousFunctionFactory->create([new Param($itemVariable)], $stmts, null);
 

diff --git a/...teMethodRmFromListOfGeneralUtilityRector/Fixture/remove_from_list_to_array_filter.php.inc b/...teMethodRmFromListOfGeneralUtilityRector/Fixture/remove_from_list_to_array_filter.php.inc
@@ -9,6 +9,11 @@ $list = '1,2,3';
 
 $newList = GeneralUtility::rmFromList($element, $list);
 
+$newElementVarName = '1';
+$newListVarName = '1,2,3';
+
+$newListTwo = GeneralUtility::rmFromList($newElementVarName, $newListVarName);
+
 ?>
 -----
 <?php
@@ -24,4 +29,11 @@ $newList = implode(',', array_filter(explode(',', $list), function ($item) use (
     return $element == $item;
 }));
 
+$newElementVarName = '1';
+$newListVarName = '1,2,3';
+
+$newListTwo = implode(',', array_filter(explode(',', $newListVarName), function ($item) use ($newElementVarName) {
+    return $newElementVarName == $item;
+}));
+
 ?>