[TASK] Improve nesting of TranslationFileRector

sabbelasichon · Dec 3, 2023 · eec9846 · eec9846
1 parent e04e26e
commit eec9846
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/src/FileProcessor/Yaml/Form/Rector/v10/v0/TranslationFileRector.php b/src/FileProcessor/Yaml/Form/Rector/v10/v0/TranslationFileRector.php
@@ -62,22 +62,24 @@ public function refactor(array $yaml): array
 
     /**
      * @param mixed[] $yaml
-     *
      * @return mixed[]
+     * @see https://github.com/TYPO3/typo3/blob/10.4/typo3/sysext/form/Classes/Controller/FormEditorController.php#L653-L689
      */
     private function refactorTranslationFile(array &$yaml): array
     {
         foreach ($yaml as &$section) {
-            if (is_array($section)) {
-                if (array_key_exists(self::TRANSLATION_FILE_KEY, $section) && is_array(
-                    $section[self::TRANSLATION_FILE_KEY]
-                )) {
-                    $section['translationFiles'] = $this->buildNewTranslations($section[self::TRANSLATION_FILE_KEY]);
-                    unset($section[self::TRANSLATION_FILE_KEY]);
-                }
+            if (! is_array($section)) {
+                continue;
+            }
 
-                $this->refactorTranslationFile($section);
+            if (array_key_exists(self::TRANSLATION_FILE_KEY, $section)
+                && is_array($section[self::TRANSLATION_FILE_KEY])
+            ) {
+                $section['translationFiles'] = $this->buildNewTranslations($section[self::TRANSLATION_FILE_KEY]);
+                unset($section[self::TRANSLATION_FILE_KEY]);
             }
+
+            $this->refactorTranslationFile($section);
         }
 
         unset($section);