Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoveLanguageModeMethodsFromTypo3QuerySettingsRector not fully migrating #3240

Closed
helsner opened this issue Jan 24, 2023 · 0 comments · Fixed by #4039
Closed

RemoveLanguageModeMethodsFromTypo3QuerySettingsRector not fully migrating #3240

helsner opened this issue Jan 24, 2023 · 0 comments · Fixed by #4039
Labels
Bug

Comments

@helsner
Copy link
Collaborator

helsner commented Jan 24, 2023

latest version

Minimal PHP Code Causing Issue

$query = $this->createQuery();
$query->getQuerySettings()->setRespectSysLanguage(false);
$query->getQuerySettings()->setLanguageOverlayMode(false);
$query->getQuerySettings()->setLanguageMode('ignore');

Expected Behaviour

The last line should be removed which does not happen
@helsner helsner added the Bug label Jan 24, 2023
sabbelasichon added a commit that referenced this issue Jan 24, 2024
@sabbelasichon
BUGFIX: Fix missing removal
60e6d5f 
Resolves: #3240
@sabbelasichon sabbelasichon mentioned this issue Jan 24, 2024
Merged
sabbelasichon added a commit that referenced this issue Jan 24, 2024
@sabbelasichon @actions-user
[BUGFIX]: Fix missing removal (#4039)
6f5de39 
* BUGFIX: Fix missing removal

Resolves: #3240

* [CI] Rector Rectify

---------

Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX]: Fix missing removal sabbelasichon/typo3-rector
1 participant
@helsner