Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type input field with eval defined falsely migrated to type number #3923

Closed
nhovratov opened this issue Nov 20, 2023 · 0 comments · Fixed by #3924
Closed

Type input field with eval defined falsely migrated to type number #3923

nhovratov opened this issue Nov 20, 2023 · 0 comments · Fixed by #3924
Labels
Bug

Comments

@nhovratov
Copy link
Contributor

Bug Report

Rector 0.17.0

Minimal PHP Code Causing Issue

            'label' => 'input field',
            'config' => [
                'type' => 'input',
                'eval' => 'trim',
            ],

Expected Behaviour

Normal input fields should not be migrated to type number.
@nhovratov nhovratov added the Bug label Nov 20, 2023
nhovratov added a commit to nhovratov/typo3-rector that referenced this issue Nov 20, 2023
@nhovratov
[BUGFIX] Prevent false migration from type input to type number
cbc1e17 
An early return is added, in case the eval list doesn't contain neither
`int` nor `double`.

Fixes: sabbelasichon#3923
@nhovratov nhovratov mentioned this issue Nov 20, 2023
Merged
sabbelasichon pushed a commit that referenced this issue Nov 20, 2023
@nhovratov @sabbelasichon
[BUGFIX] Prevent false migration from type input to type number
3e9263b 
An early return is added, in case the eval list doesn't contain neither
`int` nor `double`.

Fixes: #3923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Prevent false migration from type input to type number nhovratov/typo3-rector
1 participant
@nhovratov