Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $this->nodesToAddCollector-> call directly for addNodes?(?:Before|After)Node call #2818

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Use $this->nodesToAddCollector-> call directly for addNodes?(?:Before|After)Node call #2818

merged 2 commits into from
Feb 28, 2022

Conversation

samsonasik
Copy link
Contributor

@samsonasik samsonasik commented Feb 28, 2022 •
edited
Loading

To be able to remove deprecated methods addNodes?(?:Before|After)Node on AbstractRector, ref rectorphp/rector-src#1879

@samsonasik samsonasik mentioned this pull request Feb 28, 2022
Merged
@samsonasik
Copy link
Contributor Author

All checks have passed 🎉 @sabbelasichon @TomasVotruba it is ready for review.

@sabbelasichon sabbelasichon merged commit 6ba407d into sabbelasichon:main Feb 28, 2022
@samsonasik samsonasik deleted the use-nodes-to-add-collector branch February 28, 2022 06:30
@TomasVotruba
Copy link
Contributor

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @TomasVotruba @sabbelasichon