Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Use value property of getSeverity() #3124

Merged
merged 5 commits into from
Sep 26, 2022
Merged

[TASK] Use value property of getSeverity() #3124

merged 5 commits into from
Sep 26, 2022

Conversation

tomasnorre
Copy link
Contributor

Resolves #3092

@tomasnorre
Copy link
Contributor Author

tomasnorre commented Sep 9, 2022 •
edited
Loading

The tests are failing in files that I haven't touched, due to incomplete tests.

PHPStan is failing due to the latest update:

  • Upgrading phpstan/phpstan (1.8.2 => 1.8.5)

This is the PHPStan update locally. But I don't know if it's from 1.8.2 to 1.8.3 or where the "problem" lies. With 1.8.2 PHPstan works locally.

How should I deal with this?

Edit: FYI I'm out for two weeks of vacation from this afternoon.

@tomasnorre tomasnorre marked this pull request as ready for review September 9, 2022 06:37
@sabbelasichon
Copy link
Owner

@tomasnorre Thanks Tomas. I have updated PHPStan and Rector and the errors are gone.

@sabbelasichon sabbelasichon merged commit 9195964 into sabbelasichon:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helsner helsner Awaiting requested review from helsner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking: #97787 - AbstractMessage->getSeverity() returns ContextualFeedbackSeverity
3 participants
@tomasnorre @sabbelasichon @helsner