[FEATURE] Add migration to associative items array keys #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, first contribution here. I have no idea how php parser works. Need to learn it first to complete this PR. I don't mind, if someone picks this up. Test fixtures are set up. And: Thank you for this great tool. It helped me already many times while updating TYPO3 instances. Edit: Learned a bit how to use expressions / nodes and implemented the migration. Please have a look whether this is the way to go. |
|
@nhovratov Thank you very much. Awesome to see new people contributing to the project. I will have a look soon. |
helsner
reviewed
Apr 25, 2023
tests/Rector/v12/v3/tca/MigrateItemsIndexedKeysToAssociativeRector/Fixture/fixture.php.inc
Outdated
Show resolved
Hide resolved
|
I guess this could be the most wanted rector rule for TYPO3 v12 upgrades. |
|
@sabbelasichon can you check along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3399