fix: invalid URL error #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for saber ready! Built with commit 68a4ae1 |
egoist
reviewed
May 2, 2019
|
|
Are you sure about that? last time I checked it's only the pathname. |
|
I checked and it appears that |
egoist
reviewed
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e596812 introduced an issue by swapping deprecated
url.parse()for the newer WHATWG api:https://github.com/egoist/saber/blob/e596812f21aefc8b0206883f61af257bfa51b5a4/packages/saber/vue-renderer/lib/index.js#L420
req.urlis a relative URL. Unfortunately, the new API only works with absolute URLs and throws an error whenever an invalid URL is passed - a relative URL is invalid. Thrown error means Saber crashes. See https://nodejs.org/api/url.html#url_constructor_new_url_input_base for more info.