Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category badges added #26

Merged
merged 5 commits into from
Dec 12, 2021
Merged

Category badges added #26

merged 5 commits into from
Dec 12, 2021

Conversation

Mathursan-007
Copy link
Contributor

@Mathursan-007 Mathursan-007 commented Nov 25, 2021 •
edited
Loading

issue #1

  • Category theme is not found.
  • All category tags were added to the bottom of the card
    image

@sabesansathananthan
Copy link
Owner

Hey Can you check this page
I expected like the below screenshot
Screenshot from 2021-11-25 23-12-20.
you can download and play with this repo..
Don't worry about the styling. It is already added in the assert file.

@Mathursan-007
Copy link
Contributor Author

Mathursan-007 commented Dec 4, 2021 •
edited
Loading

Hey,
The changes have been made as you said.

  • Categories are merged and sorted based on the number of counts(Ascending).
  • Each post will consist of a badge with the matching category tag of it, which is chosen based on the highest preference in the sorted list of categories.
  • Badge's color is differentiated based on the category.

sabesansathananthan
sabesansathananthan requested changes Dec 9, 2021
View reviewed changes
Copy link
Owner

@sabesansathananthan sabesansathananthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested change

src/components/Slider.js Outdated
if (blogsWithTag.length > 0) {
blogsWithTag.forEach(item => {
item[`tag`] = sortedTagsArray[i];
item['tagNo'] = i + 1;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag No is wrong Correct it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

sabesansathananthan
sabesansathananthan approved these changes Dec 12, 2021
View reviewed changes
Copy link
Owner

@sabesansathananthan sabesansathananthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR

@sabesansathananthan sabesansathananthan merged commit 896b271 into sabesansathananthan:master Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabesansathananthan sabesansathananthan sabesansathananthan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mathursan-007 @sabesansathananthan