[pull] main from systemd:main #138
Open
+483,977
−293,461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Follow-up for ff68472
When the option is not available unit will not even start so there is no security risk. Fixes #34983
If bus_add_match_full() is called without install callback and we failed to install the signal match e.g. by timeout, then add_match_callback() will disconnect from the bus. Let's use a custom install handler and handle failures gracefully. This does not *solve* the root cause of issue #30573, but should improve the situation when the issue is triggered.
These section contains not only DUID related settings. Follow-up for 418f2dc.
Typically, the same client identifier setting is used for all interfaces. Hence, better to provide the system-wide setting to specify the client identifier.
Force-pushed as usual, now HEAD is v257.1.
Please backport the first commit to stable.
Otherwise, the build fails with:
```
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /mnt/work/src/systemd/upstream-fork/main/build-mkosi
ninja: Entering directory `/mnt/work/src/systemd/upstream-fork/main/build-mkosi'
[463/2561] Compiling C object src/shared/libsystemd-shared-258.a.p/openssl-util.c.o
FAILED: src/shared/libsystemd-shared-258.a.p/openssl-util.c.o
cc -Isrc/shared/libsystemd-shared-258.a.p -Isrc/shared -I../src/shared -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I. -I.. -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-json -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-path -I../src/libsystemd/sd-resolve -I../src/libsystemd/sd-varlink -I/usr/include/blkid -I/usr/include/libmount -I/usr/include/p11-kit-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -Wno-missing-field-initializers -Wno-unused-parameter -Wno-nonnull-compare -Warray-bounds -Warray-bounds=2 -Wdate-time -Wendif-labels -Werror=format=2 -Werror=format-signedness -Werror=implicit-function-declaration -Werror=implicit-int -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=missing-declarations -Werror=missing-prototypes -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=strict-flex-arrays -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wzero-length-bounds -fdiagnostics-show-option -fno-common -fstack-protector -fstack-protector-strong -fstrict-flex-arrays=3 --param=ssp-buffer-size=4 -Wno-unused-result -Werror=shadow -fPIC -fno-strict-aliasing -fstrict-flex-arrays=1 -fvisibility=hidden -fno-omit-frame-pointer -include config.h -pthread -fvisibility=default -MD -MQ src/shared/libsystemd-shared-258.a.p/openssl-util.c.o -MF src/shared/libsystemd-shared-258.a.p/openssl-util.c.o.d -o src/shared/libsystemd-shared-258.a.p/openssl-util.c.o -c ../src/shared/openssl-util.c
../src/shared/openssl-util.c: In function ‘openssl_ask_password_ui_read’:
../src/shared/openssl-util.c:1395:65: error: implicit declaration of function ‘UI_method_get_ex_data’; did you mean ‘UI_method_get_reader’? [-Wimplicit-function-declaration]
1395 | AskPasswordRequest *req = (AskPasswordRequest*) UI_method_get_ex_data(UI_get_method(ui), 0);
| ^~~~~~~~~~~~~~~~~~~~~
| UI_method_get_reader
../src/shared/openssl-util.c:1395:65: warning: nested extern declaration of ‘UI_method_get_ex_data’ [-Wnested-externs]
../src/shared/openssl-util.c:1395:43: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
1395 | AskPasswordRequest *req = (AskPasswordRequest*) UI_method_get_ex_data(UI_get_method(ui), 0);
| ^
../src/shared/openssl-util.c: In function ‘openssl_ask_password_ui_new’:
../src/shared/openssl-util.c:1479:13: error: implicit declaration of function ‘UI_method_set_ex_data’; did you mean ‘UI_method_set_reader’? [-Wimplicit-function-declaration]
1479 | if (UI_method_set_ex_data(ui->method, 0, &ui->request) == 0)
| ^~~~~~~~~~~~~~~~~~~~~
| UI_method_set_reader
../src/shared/openssl-util.c:1479:13: warning: nested extern declaration of ‘UI_method_set_ex_data’ [-Wnested-externs]
[480/2561] Compiling C object src/shared/libsystemd-shared-258.a.p/pkcs11-util.c.o
ninja: build stopped: subcommand failed.
```
…e.org The current src.opensuse.org is very unstable and commit hashes are reset (or even removed) every now and then. While the official repo is not fixed, let's move to a more stable source, the github mirror of code.opensuse.org, maintained since 2019.
…e.org (#35789) The commit history of [src.opensuse.org](https://src.opensuse.org/pool/systemd/src/branch/devel) has been reset again to 2015 (both branches, factory and devel)... this is unusable for now. I'd suggest switching to the github mirror of code.opensuse.org, maintained since 2019 (at least github is not down that often and the commit history does not change).
Follow-up for a4c0528
Follow-up for c968d76 We'd only transition to SOCKET_CLEAN state if previously inactive (see socket_clean()), hence no fds shall be persisted in this state.
- Log about errors in socket_open_fds() - Open parent dir fd and operate under it, instead of constructing paths everywhere - Replace scandir() with readdir_all()
Prior to this commit, if no Exec*= is defined for socket, and the unit was in SOCKET_FAILED state, failure of socket_open_fds() would induce state transition SOCKET_FAILED -> SOCKET_FAILED, and OnFailure= deps get unexpectedly skipped. Let's introduce an intermediate state, so that during unit start we enter UNIT_ACTIVATING at least once. Fixes #35635
Currently translated at 96.8% (249 of 257 strings) Co-authored-by: Ettore Atalan <atalanttore@googlemail.com> Translate-URL: https://translate.fedoraproject.org/projects/systemd/main/de/ Translation: systemd/main
This is something I think we should have added a long time ago: a flavour of open() that safely ensures the inode we are opening is a regular file, before we open it. It does this by means of pinning the inode via O_PATH first, and after verification actually opening it. This ports some code over to this, but sooner or later we should probably use this a lot more, so that we don't accidentally open weird stuff such as device nodes or pipes, where we should not.
p->format is not guaranteed to be initialized.
Let's nuke this out-of-date doc in favor of HACKING.md.
Also wait for created devices being processed before running tests.
Co-authored-by: David Tardon <dtardon@redhat.com>
Co-authored-by: David Tardon <dtardon@redhat.com>
Required by gdb-add-index to find gdb and not declared as a dependency of the package.
After #35074, the parameter 'req' must be non-NULL. Fixes CID#1586101, CID#1586102, and CID#1586103.
The package is logistically separated, as the rpm sources conflict from Fedora conflict with the rpm sources from SUSE (some files have the same name and location but different, incompatible content), so Fedora builds can't be triggered from the same package. The result is the same.
Poll fds associated with the bus instead of hardcoding stdin/stdout. This is consequential under socket activation, when the provided fd should be used instead of stdin/stdout.
Hopefully fixes #35302
Drop the extra `I` and rename the constant to DNS_EDE_RCODE_PROHIBITED in accordance with the error code string.
As requested, a list of kernel version to feature mapping for kernels older than minimum baseline is also included, in order to ease potential backport work.
… fails because ns type not supported This makes sure the the codepath that derives an nsfd from a pid works the same for the pidfd case and the non-pidfd case: if we can verify that /proc/ is mounted but the /proc/$PID/ns/ files are missing, we can assume the ns type is not supported by the kernel. Hence return the same ENOPKG error in this case as we already do in the pidfd ioctl based codepath.
…s_init() Let's not sloppily eat up errors here.
(This is preparation for #35685, but since it comes with nice test cases should be safe to add on their own)
These files are rendered on systemd.io and targeted at contributors, not users, so it's not really useful to install them on a running system.
The tests might be running unprivileged or in an environment without selinux so let's not fail if we can't put it in permissive mode.
All that's needed is dist-git-source: true so remove the other settings that aren't required.
Globs inside quotes aren't expanded and we need the glob to be more specific to avoid matching multiple entries inside the tmt source directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )