Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several small changes #55

Merged
merged 9 commits into from
Feb 25, 2023
Merged

Several small changes #55

merged 9 commits into from
Feb 25, 2023

Conversation

cpiber
Copy link
Contributor

@cpiber cpiber commented Feb 24, 2023

Each of these is pretty small, so I hope it's alright to put them in one PR.

Note: I noticed that JS-.NET interaction is a bit awkward, might want to look into instance calls and interop integration.

Closes #54, #53,

@sabitertan
Copy link
Owner

Can you please update Readme according to your changes? TY!

@cpiber
Copy link
Contributor Author

cpiber commented Feb 25, 2023

Btw, unrelated to my PR, but I think the section "ImageCapture Support" is a bit misleading. It should be mentioned, that this is only needed for the capture function, not for the library as a whole. I did not even notice any problems when I used the library despite using Firefox, since I did not need the feature.

@sabitertan sabitertan merged commit 851121d into sabitertan:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception when there are no video sources
2 participants