Made it threadsafe #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, added helperclass to be able to reference the BarcodeReaderInterop instance. This makes it thread safe
|
@KeesAlderliesten Thanks for PR, this library designed to work on web assembly only but then we introduced server-side support, I didn't really use it on server-side applications, PR looks good, just verifying now. |
|
Closes #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simultaneous scanning on multiple devices triggers the OnBarcodeReceived on all devices that have the scanner open. That happens because the class with the JSInvokable attribute is static. The comment 'Unfortunately JS is unable to invoke public methods of internal classes' suggests that it is not possible to call methods in a class instance, but Microsoft docs shows that is is possible: https://learn.microsoft.com/en-gb/aspnet/core/blazor/javascript-interoperability/call-dotnet-from-javascript?view=aspnetcore-6.0#class-instance-examples
So, I removed the class JsInteropClass, made all the static methods and variables non-static, added a helper class to BlazorBarcodeScanner.js and passed the reference to the instance of BarcodeReaderInterop to that helper (in BarcodeReader.razor.cs).
Now you can scan on multiple devices without triggering all the readers at the same time