Make external vector type non-opaque #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows matching against the type in guards, without dialyzer spitting "Call does not have expected opaque term ..." errors. This goes in line with [this change on `MapSet`](https://github.com/elixir-lang/elixir/pull/11917/files). For more context on the error, see [this forum post](https://elixirforum.com/t/dialyzer-complaint-about-mapset-member-not-getting-proper-type-as-argument-possible-specs-bug-in-mapset/20780/17).
|
Hi @MegaRedHand, thanks a lot for the pull request! You're right, it seems I did fix it for I used a different strategy back then, probably to enable pattern-matching using the |
|
Will merge this and rework it to use a private type so that the contribution is kept. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for such a wonderful library! Now onto the PR changes:
This PR makes the struct a non-opaque type, and any change to the
%Aja.Vector{__vector__: ...}a breaking change. However, this allows matching against the type in guards, without dialyzer spitting "Call does not have expected opaque term ..." errors, while maintaining the opaqueness for the innerrawtype.This goes in line with this change on
MapSet. For more context on the error, see this forum post.