-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: single crate #22
Conversation
ci: remove superfluous Vercel CLI installation
closes #12
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
@gavriliumircea could we please disable these comments made by the Vercel bot? IIRC there's a setting in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I tested locally with both cargo run and Vercel dev and everything works as expected. I will do some more tests after the Vercel deployment is completed. About the comments I found a setting inside the Vercel machine configuration that should remove the comments. If this does not solve the issue I will revisit this.
Thanks @gavriliumircea, glad to hear that it works with Vercel. The only issue is that the CI checks didn't pass: I will push the fix directly to |
Yup, I just wanted to be able to test the vercel env as well. Right now there is a problem with the create function on the hosted env. Investigating right now |
Sorry for that |
Closes #6, #11, #12, and #20.
Fixes the CI by following the instructions provided here:
.cargo/config.toml
necessary in CI? vercel-community/rust#134PTAL @gavriliumircea. If everything looks good, feel free to squash & merge.