Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: single crate #22

Merged
merged 8 commits into from
Nov 27, 2023
Merged

refactor: single crate #22

merged 8 commits into from
Nov 27, 2023

Conversation

PaulRBerg
Copy link
Member

@PaulRBerg PaulRBerg commented Nov 24, 2023

Closes #6, #11, #12, and #20.

Fixes the CI by following the instructions provided here:

PTAL @gavriliumircea. If everything looks good, feel free to squash & merge.

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
v2-merkle-api ⬜️ Ignored (Inspect) Nov 24, 2023 7:06pm

@PaulRBerg
Copy link
Member Author

@gavriliumircea could we please disable these comments made by the Vercel bot? IIRC there's a setting in vercel.json for this

Copy link
Collaborator

@gavriliumircea gavriliumircea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I tested locally with both cargo run and Vercel dev and everything works as expected. I will do some more tests after the Vercel deployment is completed. About the comments I found a setting inside the Vercel machine configuration that should remove the comments. If this does not solve the issue I will revisit this.

@gavriliumircea gavriliumircea merged commit 20c00f2 into main Nov 27, 2023
2 of 4 checks passed
@PaulRBerg PaulRBerg deleted the refactor/single-crate branch November 27, 2023 08:40
@PaulRBerg
Copy link
Member Author

PaulRBerg commented Nov 27, 2023

Thanks @gavriliumircea, glad to hear that it works with Vercel.

The only issue is that the CI checks didn't pass:

SCR-20231127-jtfo

I will push the fix directly to main but for future PRs, let's ensure that the CI passes before merging.

@gavriliumircea
Copy link
Collaborator

Yup, I just wanted to be able to test the vercel env as well. Right now there is a problem with the create function on the hosted env. Investigating right now

@PaulRBerg
Copy link
Member Author

Sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deploy github action
2 participants