Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all tests to use Bulloak #799

Closed
PaulRBerg opened this issue Jan 23, 2024 · 6 comments
Closed

Refactor all tests to use Bulloak #799

PaulRBerg opened this issue Jan 23, 2024 · 6 comments
Assignees
@smol-ninja
Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

See:
@PaulRBerg PaulRBerg added effort: epic Multi-stage task that may require multiple PRs. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Jan 23, 2024
@andreivladbrg
Copy link
Member

I would mark this as priority 3

@PaulRBerg PaulRBerg added priority: 3 Nice-to-have. Willing to ship without this. and removed priority: 2 We will do our best to deal with this. labels Jan 23, 2024
@smol-ninja smol-ninja mentioned this issue Jan 24, 2024
Closed
@PaulRBerg
Copy link
Member Author

Can we please switch to Bulloak in the next release, or at least do it in open-ended?

Reviewing PRs that modify BTs without Bulloak is a pain

@PaulRBerg PaulRBerg added priority: 2 We will do our best to deal with this. and removed priority: 3 Nice-to-have. Willing to ship without this. labels Apr 5, 2024
@smol-ninja
Copy link
Member

Yeah lets do it in next release as well as use it in the first release of open-ended.

@smol-ninja smol-ninja mentioned this issue Apr 5, 2024
Closed
@smol-ninja smol-ninja mentioned this issue Jun 8, 2024
Merged
@smol-ninja smol-ninja self-assigned this Aug 13, 2024
@smol-ninja
Copy link
Member

I am thinking of working on it since its been pending for a very long time and as we have seen in Flow, its useful too. Any objections since it could be a huge refactor?

@PaulRBerg
Copy link
Member Author

No objections. Just excitement!

This was referenced Aug 20, 2024
Merged
Merged
@smol-ninja
Copy link
Member

I have finished this. There are two PRs:

  1. test(refactor): core tests to use Bulloak #1022 for core
  2. test(refactor): periphery tests to use Bulloak #1025 for periphery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smol-ninja smol-ninja

Labels
effort: epic Multi-stage task that may require multiple PRs. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smol-ninja @PaulRBerg @andreivladbrg