test(refactor): core tests to use Bulloak

[smol-ninja]

Partially closes #799

Tasks

• Refactor core tests to comply to bulloak check
• Rewrite core tests to conform to BTT specs

[smol-ninja]

This PR is now ready for review. I will create a separate PR for periphery so that it will be easier to manage conflicts with #1024.

[andreivladbrg]

Before leaving a full review, I can see that you've used in tree branches the "is" verb.

e.g.

v2-core/test/core/integration/concrete/lockup-dynamic/create-with-timestamps/createWithTimestamps.tree

Lines 5 to 19 in d689390

	├── when sender is zero address
	│ └── it should revert
	└── when sender is not zero address
	├── when recipient is zero address
	│ └── it should revert
	└── when recipient is not zero address
	├── when deposit amount is zero
	│ └── it should revert
	└── when deposit amount is not zero
	├── when start time is zero
	│ └── it should revert
	└── when start time is not zero
	├── when segment count is zero
	│ └── it should revert
	└── when segment count is not zero

On flow repo, we have discussed about it and we have reached a common ground that it is better to not use it.

Did you change your mind? Or is it good to be changed?

[smol-ninja]

Agree. "is" doesn't need to be there. You can go ahead and change it in this case.

[andreivladbrg]

Thanks for the PR Shub.

I must say, the .tree files now look muuuch better and feel fresher. Having long branches, it was super mentally exhausting when choosing one. It’s like going from the polluted city center to the fresh air in the mountains, haha.

---

re does not and not, i guess you used the shorter form for consistency, right?

[smol-ninja]

It’s like going from the polluted city center to the fresh air in the mountains

Indeed. Or more like cleaning the polluted city 😬

[PaulRBerg]

Unfortunately, I am unable to review this at the moment. I will review all recent work in the Lockup repo when I perform a massive audit before the next launch.

[andreivladbrg]