feat: use createWithTimestamps in claim
#1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add START_TIME in MerkleLT refactor: use createWithTimestamps in claim function
test: update tests accordingly
2 tasks
smol-ninja
added a commit
that referenced
this pull request
Aug 28, 2024
smol-ninja
changed the title
createWithTimestamps in claimcreateWithTimestamps in claim
smol-ninja
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Thanks for the PR Andrei. Please find my comments below some of which have been addressed through a separate PR #1027 as it required refactoring claim tests to include all possible branches.
Feel free to give that a review. Let me know if you have any question.
test/periphery/integration/merkle-campaign/factory/create-merkle-lt/createMerkleLT.t.sol
Outdated
Show resolved
Hide resolved
test/periphery/integration/merkle-campaign/lt/claim/claim.t.sol
Outdated
Show resolved
Hide resolved
test/periphery/integration/merkle-campaign/ll/claim/claim.t.sol
Outdated
Show resolved
Hide resolved
Merged
|
@smol-ninja merged the PR here, lmk if it looks good now |
andreivladbrg
added a commit
that referenced
this pull request
Sep 11, 2024
* feat: introduce a Schedule struct for MerkleLL feat: add START_TIME in MerkleLT refactor: use createWithTimestamps in claim function * fix: cover the case when there is no cliff * fix: implement _deployMerkleLT to prevent stack too deep error test: update tests accordingly * style: run forge fmt * fix: first tranche * perf: optimize _calculateStartTimeAndTranches * test: increase coverage * test: dry fy claim tests * remove redundant struct * feedback on PR #1024 (#1027) * feedback on PR #1024 * address feedback --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com> --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
andreivladbrg
added a commit
that referenced
this pull request
Oct 8, 2024
* feat: introduce a Schedule struct for MerkleLL feat: add START_TIME in MerkleLT refactor: use createWithTimestamps in claim function * fix: cover the case when there is no cliff * fix: implement _deployMerkleLT to prevent stack too deep error test: update tests accordingly * style: run forge fmt * fix: first tranche * perf: optimize _calculateStartTimeAndTranches * test: increase coverage * test: dry fy claim tests * remove redundant struct * feedback on PR #1024 (#1027) * feedback on PR #1024 * address feedback --------- Co-authored-by: andreivladbrg <andreivladbrg@gmail.com> --------- Co-authored-by: smol-ninja <shubhamy2015@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #996
Some problems in the issue:
MerkleLLthe case when cliff duration is 0 was not coveredMerkleLTthestartTime + MerkleLT.TrancheWithPercentage.duration // recursivelywas not correct, but only for the first tranche