Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sablier fee on Airstreams claim #1038

Open
wants to merge 13 commits into
base: staging
Choose a base branch
from

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Sep 9, 2024

Changelog

@smol-ninja smol-ninja marked this pull request as draft September 9, 2024 09:42
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've seen that you have modified the contract as per my suggestion

i do have one more question:

src/periphery/abstracts/SablierMerkleBase.sol Show resolved Hide resolved
@smol-ninja
Copy link
Member Author

This PR is now ready for review pending conclusion in #1039.

@PaulRBerg
Copy link
Member

PaulRBerg commented Sep 10, 2024

Thanks, @smol-ninja!

We need to implement some additional functionality, unfortunately.

#1040

@smol-ninja
Copy link
Member Author

smol-ninja commented Sep 10, 2024

We need to implement some additional functionality, unfortunately

No problem. How do we proceed @andreivladbrg? Should I close this PR then or should we review and merge it and then work on top of it? #1040 (comment)

@smol-ninja

This comment was marked as outdated.

@smol-ninja smol-ninja changed the title feat: receive ether in claim function feat: sablier fee on airstreams claim Sep 11, 2024
@smol-ninja smol-ninja changed the title feat: sablier fee on airstreams claim feat: sablier fee on Airstreams claim Sep 11, 2024
@smol-ninja smol-ninja marked this pull request as draft September 11, 2024 14:38
@smol-ninja smol-ninja marked this pull request as ready for review September 11, 2024 16:30
@smol-ninja
Copy link
Member Author

@andreivladbrg You can review this PR now. Its completed from my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants