build: upgrade to Solidity v0.8.18 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
prb/solc-update
branch
2 times, most recently
from
181f257 to
7c0bada
Compare
PaulRBerg
force-pushed
the
main
branch
2 times, most recently
from
1968f5a to
82c69c2
Compare
PaulRBerg
force-pushed
the
prb/solc-update
branch
4 times, most recently
from
62647bf to
b47f239
Compare
PaulRBerg
force-pushed
the
prb/solc-update
branch
from
b47f239 to
f9f3a3a
Compare
Done ✅ |
PaulRBerg
force-pushed
the
prb/solc-update
branch
4 times, most recently
from
22da4f4 to
0977f4e
Compare
PaulRBerg
force-pushed
the
prb/solc-update
branch
from
0977f4e to
2b947e3
Compare
|
I will temporarily disable Solhint in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #314 and also implements named parameters for mappings.
NOTE: the CI lint job is failing but this is becauseprettier-plugin-soliditydoesn't support named mapping parameters just yet (prettier-solidity/prettier-plugin-solidity#800).UPDATE: prettier-plugin-solidity@1.1.2 just shipped, which added support for named mapping parameters (as per prettier-solidity/prettier-plugin-solidity#803). However, the lint job is still failing, because Solhint doesn't support named mapping params just yet (protofire/solhint#397).
Changelog