Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable codecov/status check #419

Merged
merged 1 commit into from
Apr 4, 2023
Merged

chore: disable codecov/status check #419

merged 1 commit into from
Apr 4, 2023

Conversation

PaulRBerg
Copy link
Member

The Codecov status check is so often providing misleading results that it seems like it would be better to remove it.

  • It shows dubious incomplete hits, e.g. 87.50% of diff hit even if the tests have covered all added branches in PR 396
  • It reports untested code in test

This may be partly due to Foundry, as per the explanation in #332.

@PaulRBerg PaulRBerg merged commit a0333cc into main Apr 4, 2023
@PaulRBerg PaulRBerg deleted the ci/codecov-status branch April 13, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant