-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend status enum #467
Extend status enum #467
Commits on May 2, 2023
-
docs: improve writing and formatting docs: fix typos in NatSpec feat: add "_calculateStreamedAmount" in linear contract feat: add "isCanceled", "isDepleted", "isStream" fields in in stream structs perf: dedup `_withdrawableAmountOf` refactor: alphabetical ordering refactor: delete "isSettled" refactor: delete "status" field in stream structs refactor: explicit null checks refactor: improve error names refactor: move withdraw amount check in each streaming contract refactor: rename "isActive" to "isWarm" refactor: rename "getStatus" to "statusOf" test: add "has been canceled" branch in state trees test: add a new fuzz test for "cancel" test: add a new fuzz test for "withdrawMax" test: add constant "MARCH_1_2023" test: allow depleted streams in dynamic fuzz tests test: allow depleted streams in fork tests test: delete unused imports test: de-dup "streamedAmountOf" tests test: de-dup "withdrawableAmountOf" tests test: expect transfer calls in all "withdraw" fuzz tests test: improve function and variable names test: improve nesting structures in state trees test: improve wording in comments test: improve wording in state trees test: remove status check in "createWithDeltas" tests test: remove superfluous comments test: rename "whenStreamActive" to "whenStatusStreaming" test: test post-withdraw status in fork tests test: update tests in light of new contract API test: use keywords for time calculations test: various enhancements
Configuration menu - View commit details
-
Copy full SHA for eecb246 - Browse repository at this point
Copy the full SHA eecb246View commit details -
Rename `WithdrawAmountGreaterThanWithdrawableAmount` to `Overdraw` Close #458
Configuration menu - View commit details
-
Copy full SHA for 2d8ee1e - Browse repository at this point
Copy the full SHA 2d8ee1eView commit details -
docs: improve writing refactor: delete "Status.NULL" refactor: rename "isNotNull" to "notNull" refactor: rename "isWarm" to "warm" refactor: revert on null streams in "statusOf" test: add tests for "isStream" test: fix pre-conditions in "LockupHandler" test: improve function names test: refactor modifiers in "LockupHandler" test: update tests for "statusOf"
Configuration menu - View commit details
-
Copy full SHA for 68bfd90 - Browse repository at this point
Copy the full SHA 68bfd90View commit details -
feat: add "isCold" and "isWarm" utils
refactor: refactor "warm" into "notCold" refactor: rename "StreamNotWarm" error to "StreamCold" test: add tests for "isCold" and "isWarm" test: delete superfluous tests test: improve names of state trees test: improve orders of operations in tests
Configuration menu - View commit details
-
Copy full SHA for 96941f6 - Browse repository at this point
Copy the full SHA 96941f6View commit details -
test: simplify directory nesting structure
Refactor `lockup/shared` to `lockup` Refactor `lockup/linear` to `lockup-linear` Refactor `lockup/dynamic` to `lockup-dynamic`
Configuration menu - View commit details
-
Copy full SHA for eaf6bfd - Browse repository at this point
Copy the full SHA eaf6bfdView commit details -
test: check status in create function tests
test: improve writing in comments test: improve writing in function and variable names test: improve state trees
Configuration menu - View commit details
-
Copy full SHA for 52120a5 - Browse repository at this point
Copy the full SHA 52120a5View commit details -
refactor: de-dup "withdraw" and "withdrawMultiple"
docs: improve writing in comments test: remove "whenCaller" tests in "withdrawMultiple" test: fix, improve, and simplify "withdrawMultiple" tests test: fix and improve "withdraw" tests test: improve naming in state trees
Configuration menu - View commit details
-
Copy full SHA for a67a38f - Browse repository at this point
Copy the full SHA a67a38fView commit details -
Rename "WithdrawSenderUnauthorized" to "InvalidSenderWithdrawal"
Configuration menu - View commit details
-
Copy full SHA for f15e073 - Browse repository at this point
Copy the full SHA f15e073View commit details -
test: improve and simplify "cancelMultiple" tests
test: run "cancelMultiple" fuzz tests Closes #463
Configuration menu - View commit details
-
Copy full SHA for 80d0edd - Browse repository at this point
Copy the full SHA 80d0eddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b62bde - Browse repository at this point
Copy the full SHA 6b62bdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bde0f3a - Browse repository at this point
Copy the full SHA bde0f3aView commit details -
test: differentiate streams in "cancelMultiple"
test: change order of streams in "withdrawMultiple" test: use named args in expect calls helpers
Configuration menu - View commit details
-
Copy full SHA for 5faa8ec - Browse repository at this point
Copy the full SHA 5faa8ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6f2bac - Browse repository at this point
Copy the full SHA b6f2bacView commit details -
test: alphabetical ordering test: add "deployBaseTestContracts" test: add "labelBaseTestContracts" test: add "SEGMENT_COUNT" test: bound instead of assume in "createWithRange" test test: deploy base contract via bespoke helper function test: fix variable names test: improve wording in comments test: label base contracts via bespoke helper function test: delete "DEFAULT_ASSET" test: delete unneeded "Calculations" inheritance test: deploy and label base test contracts in "Base_Test.setUp" test: hard code bound values in invariant tests test: inherit from "Constants" in "Base_Test" test: improve wording in comments test: replace local max uint256 constant with PRBTest constant test: rename "dai" to "usdc"
Configuration menu - View commit details
-
Copy full SHA for e40bcbd - Browse repository at this point
Copy the full SHA e40bcbdView commit details
Commits on May 4, 2023
-
test: add invariant tests for statuses
perf: mark "isCold" and "isWarm" as "external" refactor: change declaration place of "segmentCount" test: add "assertNotEq" for "Lockup.Status" test: group status invariant tests test: improve wording
Configuration menu - View commit details
-
Copy full SHA for f7d62d5 - Browse repository at this point
Copy the full SHA f7d62d5View commit details -
test: add all shared modifiers in "streamedAmountOf" test: add all shared modifiers in "withdrawableAmountOf" test: alphabetical ordering
Configuration menu - View commit details
-
Copy full SHA for f9ca075 - Browse repository at this point
Copy the full SHA f9ca075View commit details -
test: add private "params" in shared tests test: delete internal "defaultParams" test: deploy and label directly in "Base_Test.setUp" test: define "createDefaultStreamWithTotalAmount" in shared contract text: expand "Defaults" with more default values test: use direct values instead of loading them from default params test: move statements around so make "vm.expectRevert" work test: move "Users" in "test/utils/Types" test: provide default create function params in "Defaults" test: various refactors and improvements
Configuration menu - View commit details
-
Copy full SHA for 48818a0 - Browse repository at this point
Copy the full SHA 48818a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 666d088 - Browse repository at this point
Copy the full SHA 666d088View commit details -
fix: stream not cancelable when status settled
docs: improve writing test: test cold streams in "isCancelable" test: fix mistaken comment in invariant tests
Configuration menu - View commit details
-
Copy full SHA for 4d07554 - Browse repository at this point
Copy the full SHA 4d07554View commit details
Commits on May 9, 2023
-
test: move common logic to "Lockup_Shared_Test"
test: prank back to sender after setting protocol fee
Configuration menu - View commit details
-
Copy full SHA for 6856903 - Browse repository at this point
Copy the full SHA 6856903View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f8045e - Browse repository at this point
Copy the full SHA 7f8045eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b4d237 - Browse repository at this point
Copy the full SHA 7b4d237View commit details
Commits on May 10, 2023
-
perf: remove unneeded "notNull" modifier
docs: document numerical values for "Status" enum perf: remove unneeded "streamId" variable perf: remove unneeded "uin256()" casting test: add missing error strings in assertions
Configuration menu - View commit details
-
Copy full SHA for 021362b - Browse repository at this point
Copy the full SHA 021362bView commit details
Commits on May 11, 2023
-
refactor: refactor "isCanceled" to "wasCanceled"
docs: improve writing in comments docs: remove superfluous comments
Configuration menu - View commit details
-
Copy full SHA for a3229d5 - Browse repository at this point
Copy the full SHA a3229d5View commit details -
perf: simplify withdraw functions
feat: add "_isDepleted" internal getter refactor: delete "_checkParamsAndWithdraw" function refactor: delete "StreamPending" error test: refine "cancelMultiple" and "withdrawMultiple" tests test: update state trees in light of new contract API
Configuration menu - View commit details
-
Copy full SHA for 7d21c34 - Browse repository at this point
Copy the full SHA 7d21c34View commit details -
perf: do not call "statusOf" in "cancel"
docs: improve writing in comments feat: add "_wasCanceled" getter refactor: check cold statuses directly in "renounce" refactor: delete "notCold" modifier refactor: emit specific statuses instead of "StreamCold" test: update state trees in light of new contract API
Configuration menu - View commit details
-
Copy full SHA for 3fbc3ba - Browse repository at this point
Copy the full SHA 3fbc3baView commit details -
feat: add "isDepleted" and "wasCanceled" getters
docs: improve writing in comments test: test "isDepleted" getter test: test "wasCanceled" getter
Configuration menu - View commit details
-
Copy full SHA for ac6f04a - Browse repository at this point
Copy the full SHA ac6f04aView commit details
Commits on May 12, 2023
-
refactor: merge "isDepleted" with "_isDepleted"
refactor: delete unneeded modifier uses refactor: merge "wasCanceled" with "_wasCanceled" refactor: remove "onlySenderOrRecipient" modifier
Configuration menu - View commit details
-
Copy full SHA for 2a70537 - Browse repository at this point
Copy the full SHA 2a70537View commit details