Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRB feedback on benchmarks #930

Merged
merged 1 commit into from
May 17, 2024
Merged

PRB feedback on benchmarks #930

merged 1 commit into from
May 17, 2024

Conversation

PaulRBerg
Copy link
Member

@PaulRBerg PaulRBerg commented May 16, 2024

No description provided.

@PaulRBerg PaulRBerg changed the base branch from main to staging May 16, 2024 21:01
refacotr: bnb instead of bsc
refactor: tranche instead of tranch
refactor: various misc improvements
@smol-ninja
Copy link
Member

Should we rename BSCSCAN_API_KEY to BNBSCAN_API_KEY as well?

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PaulRBerg
Copy link
Member Author

Should we rename BSCSCAN_API_KEY to BNBSCAN_API_KEY as well?

The name of the website is still bscscan, so let's stick with BSCSCAN in that case.

@PaulRBerg PaulRBerg merged commit 5616244 into staging May 17, 2024
9 checks passed
@PaulRBerg PaulRBerg deleted the prb-feedback branch May 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants