Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump solc to v0.8.26 #944

Merged
merged 2 commits into from
Jun 14, 2024
Merged

build: bump solc to v0.8.26 #944

merged 2 commits into from
Jun 14, 2024

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Jun 14, 2024

Closes #943

@PaulRBerg
Copy link
Member

Doesn't this invalidate the recent audits?

Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but let's double check that the audit reports are not invalidated

@smol-ninja
Copy link
Member Author

lgtm but let's double check that the audit reports are not invalidated

None of the finding depends on solc version. So, this should not invalidate the audit findings. cc @andreivladbrg for comments, if any.

@PaulRBerg
Copy link
Member

OK, then, let's merge it

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comments on my side

lgtm👍

@andreivladbrg andreivladbrg merged commit c152133 into staging Jun 14, 2024
9 checks passed
@smol-ninja smol-ninja deleted the bump-solc-v0.8.26 branch June 14, 2024 18:52
andreivladbrg pushed a commit that referenced this pull request Jul 3, 2024
* build: bump solc

* build: update precompiles

---------

Co-authored-by: Paul Razvan Berg <prberg@proton.me>
andreivladbrg pushed a commit that referenced this pull request Jul 3, 2024
* build: bump solc

* build: update precompiles

---------

Co-authored-by: Paul Razvan Berg <prberg@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants