refactor: disallow non alphanumeric symbols #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
refactor/non-alphanumeric-uri
branch
from
6678396
to
7a23821
Compare
andreivladbrg
force-pushed
the
refactor/non-alphanumeric-uri
branch
from
7a23821
to
c0d1ed3
Compare
refactor: alphabetical ordering refactor: return different string test: thorough concrete tests for "isAlphanumeric"
PaulRBerg
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Thanks for the lift-off, @andreivladbrg. I have made several additions and changes:
- Simplified the implementation using OR operators instead of AND
- Added thorough concrete units
- Added fuzz tests
PaulRBerg
force-pushed
the
refactor/non-alphanumeric-uri
branch
from
caf20fc
to
ffcd915
Compare
|
Separately, I opened feature requests in OpenZeppelin and Solady for implementing alphanumeric check functions: |
test: fuzz tests for "isAlphanumeric" test: shared test contract for NFT descriptor
PaulRBerg
force-pushed
the
refactor/non-alphanumeric-uri
branch
from
ffcd915
to
b3ff329
Compare
|
Should we allow From Egis audit report:
Also, even Sablier NFT contains Fixed in #960. |
|
I agree with adding support for |
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* refactor: disallow non alphanumeric symbols * feat: allow empty spaces in "isAlphanumeric" refactor: alphabetical ordering refactor: return different string test: thorough concrete tests for "isAlphanumeric" * refactor: simplify logical conditions test: fuzz tests for "isAlphanumeric" test: shared test contract for NFT descriptor --------- Co-authored-by: Paul Razvan Berg <prberg@proton.me>
andreivladbrg
added a commit
that referenced
this pull request
Jul 3, 2024
* refactor: disallow non alphanumeric symbols * feat: allow empty spaces in "isAlphanumeric" refactor: alphabetical ordering refactor: return different string test: thorough concrete tests for "isAlphanumeric" * refactor: simplify logical conditions test: fuzz tests for "isAlphanumeric" test: shared test contract for NFT descriptor --------- Co-authored-by: Paul Razvan Berg <prberg@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to make a decision, but this PR solves this finding: https://www.codehawks.com/report/clvb9njmy00012dqjyaavpl44#M-01