Remove _merkleStreamers mapping
#218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove getMerkleStreamers function test: update test accordingly
|
Thanks @andreivladbrg, reviewing now. For future PRs, it would be helpful to mention the audit finding this PR addresses: |
|
Cc @razgraf @gavriliumircea, this PR entails some changes in the subgraph. |
Could you go a bit into detail as to which changes may affect the subgraph? I don't see anything altering event signatures. Aside from maybe updating the ABIs to remove that getter (which we aren't using) is there something else we should consider? |
Sorry, meant to say that you should now obtain the addresses from the subgraph, not from the contract. Bad wording on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Merkle streamer contract inherits
Adminablecontract, which allows the admin to transfer its ownership to someone else. If that happens, the_merkleStreamerswill include incorrect data about the campaign's admin. To prevent this, I removed both the mapping and the getter function.