-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
build: bump v2-core
b4aed49
to
b117cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM.
Don't we also need a DeployDeterministicProtocol
script which deploys V2 Core from the precompiles?
I don't think so. This script is not for testing purpose. As I remember on call we had, you mentioned that we will not use the deterministic deployments anymore, should we remove them? Addressed the suggestions made, is it good to be merged? |
Hmmmmmmm ... I'm thinking that we might have to move the
Yes, but it doesn't follow that it wouldn't be useful to have the deterministic deployment scripts - just in case. Also, in the meantime, I have added a
Yes. We can consider how (and if) we implement the |
Addresses #76