Add INodeByPath interface to allow optimizing getNodeForPath #1060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1059, doing this in a separate PR so the other can stay open for the "nested tree" discussion.
A few points of detail
INodeByPath
does not extendICollection
soTree
can implement the interface without further changes, havingTree
implement this does not really provide any benefit atm though and was mostly done to support future tree nesting. It might be better to change it to extendICollection
and makeTree
implement it if we ever make a collection.INodeByPath::getNodeForPath
can returnnull
, I fear that requiring any collection implementing the interface to be able to retrieve all nodes within it's path would prevent the ability to cleanly allow nesting collections that implement the interface