Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with PHP8.0 #1296

Merged
merged 3 commits into from
Oct 4, 2020
Merged

Test with PHP8.0 #1296

merged 3 commits into from
Oct 4, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 3, 2020

  1. sort out variables in .travis.yml for selecting to run php-cs-fixer, phpunit and phpstan
  2. Add a matrix entry to run just phpunit on Ubuntu 20.04 "focal" with "nightly" PHP (which is the way to get PHP 8.0 at the moment) Note: focal does not have postgresql available by default, so addons postgresql needs to be specified in .travis.yml
  3. When not running php-cs-fixer, explicitly remove it from composer.json (because php-cs-fixer does not yet support PHP 8.0, so composer cannot sort out dependencies if we have PHP 8.0 and php-cs-fixer 2.* together)
  4. Remove default value from oldObject parameter to processICalendarChange
    fixes error https://travis-ci.org/github/sabre-io/dav/jobs/732659316
1) Sabre\CalDAV\Schedule\DeliverNewEventTest::testDelivery
Required parameter $newObject follows optional parameter $oldObject
/home/travis/build/sabre-io/dav/lib/CalDAV/Schedule/Plugin.php:612
/home/travis/build/sabre-io/dav/tests/Sabre/DAVServerTest.php:144
/home/travis/build/sabre-io/dav/tests/Sabre/DAVServerTest.php:119
/home/travis/build/sabre-io/dav/tests/Sabre/CalDAV/Schedule/DeliverNewEventTest.php:19

@phil-davis phil-davis self-assigned this Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #1296 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1296      +/-   ##
============================================
+ Coverage     97.12%   97.14%   +0.01%     
- Complexity     2774     2792      +18     
============================================
  Files           174      174              
  Lines          8028     8117      +89     
============================================
+ Hits           7797     7885      +88     
- Misses          231      232       +1     
Impacted Files Coverage Δ Complexity Δ
lib/CalDAV/Schedule/Plugin.php 99.23% <100.00%> (+0.01%) 100.00 <11.00> (ø)
lib/DAV/Server.php 96.13% <0.00%> (-0.18%) 192.00% <0.00%> (ø%)
lib/CardDAV/Card.php 100.00% <0.00%> (ø) 18.00% <0.00%> (ø%)
lib/DAVACL/FS/File.php 100.00% <0.00%> (ø) 3.00% <0.00%> (ø%)
lib/DAV/Sync/Plugin.php 100.00% <0.00%> (ø) 26.00% <0.00%> (ø%)
lib/DAVACL/Principal.php 100.00% <0.00%> (ø) 17.00% <0.00%> (ø%)
lib/CalDAV/CalendarHome.php 100.00% <0.00%> (ø) 44.00% <0.00%> (+1.00%)
lib/CalDAV/CalendarObject.php 100.00% <0.00%> (ø) 19.00% <0.00%> (ø%)
lib/CalDAV/Schedule/Inbox.php 100.00% <0.00%> (ø) 10.00% <0.00%> (ø%)
lib/CalDAV/Schedule/Outbox.php 100.00% <0.00%> (ø) 5.00% <0.00%> (ø%)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7101bbe...9769bf1. Read the comment docs.

@phil-davis
Copy link
Contributor Author

https://travis-ci.org/github/sabre-io/dav/jobs/732560846
psql: error: could not connect to server: could not connect to server: No such file or directory

ToDo: look at what is needed to make postgresql start on Ubuntu 20.04 "focal" on Travis.

@phil-davis phil-davis marked this pull request as ready for review October 4, 2020 06:19
@phil-davis
Copy link
Contributor Author

The one code change needed is exactly the same type of thing that was needed in other repos. Nothing really exciting to review here - I will merge.

@phil-davis phil-davis merged commit d3ea589 into sabre-io:master Oct 4, 2020
@phil-davis phil-davis deleted the test-php-8.0 branch October 4, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant