Latest php cs fixer 2.17.1 #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
latest-php-cs-fixer-2.17.1
branch
from
9420469 to
7c80064
Compare
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
============================================
- Coverage 97.14% 97.12% -0.03%
+ Complexity 2793 2775 -18
============================================
Files 174 174
Lines 8119 8025 -94
============================================
- Hits 7887 7794 -93
+ Misses 232 231 -1
Continue to review full report at Codecov.
|
This was referenced Dec 13, 2020
staabm
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1314 got errors from php-cs-fixer because the latest php-cs-fixer finds more things.
Adjust the code for the latest php-cs-fixer and update the required version of php-cs-fixer in composer.json (we do not want to bother running some old version of that)
Explicitly select PHP 8.0 in CI
Remove test suites that have no tests folder - the latest version of phpunit checks and fails if there is a test suite mentioned in
phpunit.xmlthat does not exist. The tests ofeventandurihave actually not been running insidedavCI for a few years. Now CI tells us about this. The tests for these repos were removed from the distribution a while ago, in PRs export ignore examples & tests in distribution event#54 and Exclude files in production uri#29This gets CI green in
sabre-io/dav. We can separately discuss if we really do want to be running those tests ofeventanduriinsidedavCI. If so, we can revert those PRs, which will put thetestsfolder back into the distribution of those repos.