Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpdoc return type of findByUri in BackendInterface #1371

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Nov 30, 2021

Fix phpdoc return type of findByUri

Fixes #1370

Fix phpdoc return type of findByUri
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1371 (3c648d0) into master (af125a4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1371   +/-   ##
=========================================
  Coverage     97.35%   97.35%           
  Complexity     2810     2810           
=========================================
  Files           174      174           
  Lines          7978     7978           
=========================================
  Hits           7767     7767           
  Misses          211      211           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af125a4...3c648d0. Read the comment docs.

@phil-davis phil-davis merged commit f8c1acc into sabre-io:master Nov 30, 2021
@phil-davis
Copy link
Contributor

I published https://github.com/sabre-io/dav/releases/tag/4.2.1 for this just now. It might as well be "out there" so people don't get warnings from code analysers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent return type for \Sabre\DAVACL\PrincipalBackend\BackendInterface::findByUri
2 participants