Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 in CI #1421

Merged
merged 1 commit into from
Oct 9, 2022
Merged

PHP 8.2 in CI #1421

merged 1 commit into from
Oct 9, 2022

Conversation

phil-davis
Copy link
Contributor

  • add PHP 8.2 to CI
  • also run the standard CI (non-streaming) with PHP 8.1 (which already runs with the streaming option)

@phil-davis phil-davis self-assigned this Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Merging #1421 (cd5e32c) into master (5c4fb8e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1421   +/-   ##
=========================================
  Coverage     97.23%   97.23%           
  Complexity     2830     2830           
=========================================
  Files           175      175           
  Lines          8566     8566           
=========================================
  Hits           8329     8329           
  Misses          237      237           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis phil-davis marked this pull request as ready for review October 9, 2022 09:41
@phil-davis
Copy link
Contributor Author

That was easy - everything still passes with PHP 8.2

@phil-davis phil-davis merged commit 264f567 into sabre-io:master Oct 9, 2022
@phil-davis phil-davis deleted the php-8.2-in-ci branch October 9, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant