Align createFile signature with interface #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1422 +/- ##
=========================================
Coverage 97.23% 97.23%
Complexity 2830 2830
=========================================
Files 175 175
Lines 8566 8566
=========================================
Hits 8329 8329
Misses 237 237
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kesselb
force-pushed
the
debt/noid/param-name-mismatch
branch
from
b8cf0af
to
051e6b9
Compare
$calendarData => $data $vcardData => $data $filename => $name Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
debt/noid/param-name-mismatch
branch
from
051e6b9
to
0481eca
Compare
kesselb
changed the title
DeepDiver1975
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Psalm is reporting some ParamNameMismatch warnings.
Here is a good explanation: https://psalm.dev/articles/getting-ready-for-named-arguments