fix: The WebDAV response element must only contain propstat OR status element(s)

[susnux]

• Resolves Response must not contain stats **and** propstat #1487

The response element should look like, see section-14.24 :
<!ELEMENT response (href, ((href*, status)|(propstat+)), error?, responsedescription? , location?) >

Meaning it

• Must contain a href ✔️
• Might contain error, responsedescription and location (not implemented by us) ✅
• Must EITHER contain a status OR one or more propstat elements

So we have to ensure the status is only set if there is no propstat.

[skjnldsv]

@DeepDiver1975 @evert who have review rights and/or who can we ping to try to get this forward? :)

[susnux]

Fixed the unit tests (some existing ones were expecting incorrect data (status AND a propstat while only on of both is allowed).

[susnux]

who have review rights and/or who can we ping to try to get this forward? :)

Maybe @phil-davis ?

[evert]

I don't see a problem with this change, and does seem like we got this wrong. I'm curious if you are running into any incompatibilities with specific clients.

[codecov]

Codecov Report

Merging #1488 (abf971d) into master (a74464d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1488      +/-   ##
============================================
- Coverage     97.34%   97.32%   -0.03%     
  Complexity     2830     2830              
============================================
  Files           175      175              
  Lines          9418     9419       +1     
============================================
- Hits           9168     9167       -1     
- Misses          250      252       +2     

Files	Coverage Δ
lib/DAV/Xml/Element/Response.php	93.58% <100.00%> (-2.52%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[skjnldsv]

I don't see a problem with this change, and does seem like we got this wrong. I'm curious if you are running into any incompatibilities with specific clients.

We actually faced that issue here: nextcloud/server#40474
Rewriting part of our frontend properly, we realized the backend was not responding accordingly :)

We're using the webdav-client node library