Allow for custom iTipBroker #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/CalDAV/Schedule/Plugin.php
Outdated
| /** | ||
| * Returns an instance of the iTip\Broker | ||
| * | ||
| * @return Broker |
There was a problem hiding this comment.
Needs an import and please use a return type hint
|
@phil-davis I hope this change makes sense. We add the protected factory method so that sub classes of the plugin can work with a sub-classed broker as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1559 +/- ##
=========================================
Coverage 97.24% 97.24%
- Complexity 2834 2836 +2
=========================================
Files 175 175
Lines 8843 8852 +9
=========================================
+ Hits 8599 8608 +9
Misses 244 244 ☔ View full report in Codecov by Sentry. |
|
@SebastianKrupinski can you please fix the issue raised by cs-fixer? THX |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
allow-custom-itipbroker
branch
from
cd9edc4 to
b64d2aa
Compare
|
@DeepDiver1975 Done. |
DeepDiver1975
approved these changes
Sep 6, 2024
NameNoQuality
approved these changes
Oct 14, 2024
phil-davis
pushed a commit
to phil-davis/dav
that referenced
this pull request
Oct 29, 2024
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
phil-davis
added a commit
that referenced
this pull request
Oct 29, 2024
Allow for custom iTipBroker (#1559) [4.6]
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a protected function to generate the iTipBroker so that is can be overriden and used to generate a custom broker class.