refactor: Change class strings to ::class constants #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1562 +/- ##
=========================================
Coverage 97.24% 97.24%
- Complexity 2834 2836 +2
=========================================
Files 175 175
Lines 8843 8852 +9
=========================================
+ Hits 8599 8608 +9
Misses 244 244 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
commented
Sep 16, 2024
| @@ -12,7 +12,7 @@ class ACLTest extends \PHPUnit\Framework\TestCase | |||
| public function testConstruct() | |||
| { | |||
| $acl = new Acl([]); | |||
| self::assertInstanceOf('Sabre\DAVACL\Xml\Property\ACL', $acl); | |||
| self::assertInstanceOf(\Sabre\DAVACL\Xml\Property\Acl::class, $acl); | |||
There was a problem hiding this comment.
^ small casing issue revealed by the refactoring :)
phil-davis
approved these changes
Nov 5, 2024
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a scripted refactoring to replace class strings with ::class constant references.
I chose not to import the classes to keep the diff clean.