Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest cs-fixer changes #109

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 28, 2023

The latest cs-fixer does not like having "useless" PHP doc that declares a var or param to be mixed.
But phpstan complains when the param has no type declaration.

The workaround is to keep the mixed PHPdoc declarations, and add some text description to them. That makes cs-fixer think that they are not useless.

It's a bit annoying having to do this, but it is not completely stupid and does get both tools to pass.

@phil-davis phil-davis self-assigned this Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #109 (08151ed) into master (fea6ea5) will not change coverage.
The diff coverage is n/a.

❗ Current head 08151ed differs from pull request most recent head 1ee3b49. Consider uploading reports for the commit 1ee3b49 to get more accurate results

@@            Coverage Diff            @@
##             master     #109   +/-   ##
=========================================
  Coverage     99.73%   99.73%           
  Complexity      109      109           
=========================================
  Files             7        7           
  Lines           376      376           
=========================================
  Hits            375      375           
  Misses            1        1           
Impacted Files Coverage Δ
lib/Promise.php 100.00% <ø> (ø)
lib/Promise/functions.php 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@phil-davis phil-davis marked this pull request as ready for review June 28, 2023 10:23
@phil-davis phil-davis requested a review from staabm June 28, 2023 10:23
@phil-davis phil-davis merged commit dc866d0 into sabre-io:master Jun 28, 2023
@phil-davis phil-davis deleted the apply-cs-fixer-changes branch June 28, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants