Skip to content

Commit

Permalink
fix(storefront): BCTHEME-354 If multiple Pick List Options are applie…
Browse files Browse the repository at this point in the history
…d, customers cannot select 'none' on both (bigcommerce#1975)
  • Loading branch information
BC-tymurbiedukhin authored and sacr3dc0w committed Mar 31, 2021
1 parent c23c85c commit 4bb6e28
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- If multiple Pick List Options are applied, customers cannot select "none" on both. [#1975](https://github.com/bigcommerce/cornerstone/pull/1975)
- Moved phrase from compare.html to en.json for increasing localization. [#1972](https://github.com/bigcommerce/cornerstone/pull/1972)
- Fixed focus for sort by dropdown on reloading page. [#1964](https://github.com/bigcommerce/cornerstone/pull/1964)
- Fixed filtered selection not announced by screen reader. [#1966](https://github.com/bigcommerce/cornerstone/pull/1966)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/options/product-list.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
type="radio"
name="attribute[{{id}}]"
value=""
id="attribute_productlist_{{../id}}_none"
id="attribute_productlist_{{id}}_none"
checked="{{#if defaultValue '==' ''}}checked{{/if}}">
<label class="form-label" for="attribute_productlist_{{../id}}_none">{{lang 'products.none'}}</label>
<label class="form-label" for="attribute_productlist_{{id}}_none">{{lang 'products.none'}}</label>
</li>
{{/unless}}
{{#each values}}
Expand Down

0 comments on commit 4bb6e28

Please sign in to comment.