Skip to content

Commit

Permalink
Cornerstone update 5.0.0 (#38)
Browse files Browse the repository at this point in the history
* Update Faceted Search files

- Componentize navigation
- Remove some extraneous whitespace
- Remove unneeded “../“
- Remove unneeded Replace helper
- Move “Remove” link outside button

* Add Spacing between SASS declarations

* feature(storefront): BCTHEME-68 Add tooltips for carousel Previous and Next buttons

* feature(storefront): BCTHEME-74 As a shopper I want to have the add to cart modal immediately have keyboard focus

* handlebars and instead 2 if for carousel buttons

* fix(storefront): BCTHEME-125 Cart remove 'X' should be a button

* feature(storefront): BCTHEME-133 Improper footer heading hierarchy

* fix(storefront): Fix main logo display on mobile with expanded menu

* feature(storefront): BCTHEME-134 Incorrect focus order on PDPs

* feature(storefront): BCTHEME-142 Unnecessary heading on product cards

* feat(payments): PAYPAL-627 Render in the site footer verbiage about Credit Broker License

* STRF-8599 Drop jquery

* Releasing 4.9.0-strf-8599-rc-1.0

* Releasing 4.9.0-strf-8599-rc-1.0

* Releasing 4.9.0-strf-8599-rc-1.0

* Releasing 4.9.0-strf-8599-rc-1.0

* Revert STRF-8599

* update config.json

* fix(storefront):BCTHEME-43 fix overlaping on footer columns when long texts are entered (bigcommerce#1753)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME154: fix issue with add product to cart on ie11 (bigcommerce#1762)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feature(storefront): BCTHEME-157 Improper heading hierarchy on Sitemap (bigcommerce#1774)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feature(storefront): BCTHEME-158 Improper heading hierarchy on Cart page (bigcommerce#1775)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-132 Visually hidden cart link read by screen reader (bigcommerce#1770)

* fix(storefront): bctheme-150 fixed issue with store logo on mobile (bigcommerce#1767)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-128 Error messages from Write a Review form should be announced (bigcommerce#1777)

* feat(storefront): BCTHEME-127 Product ratings on PDPs should have aria-hidden=true (bigcommerce#1769)

* feature(storefront): BCTHEME-156 Selected state on search page not announced (bigcommerce#1788)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-139 Unnecessary heading tag in carousel (bigcommerce#1780)

* fix(storefront): BCTHEME-146 Improper heading hierarchy on Add to Cart modal heading (bigcommerce#1783)

* fix(storefront): BCTHEME-147 Improper heading hierarchy on Add to Cart modal recommendation (bigcommerce#1784)

* fix(storefront): BCTHEME-153 Insufficient link text (bigcommerce#1786)

* fix(storefront): BCTHEME-144 Button inputs with the same name attribute should be part of a group (bigcommerce#1792)

* fix(storefront): BCTHEME-159 IDs used in ARIA and labels are not unique (bigcommerce#1791)

* BCTHEME-160: add valid ARIA role for Related Products tab (bigcommerce#1782)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-35 Cornerstone - Cart link not visible on mobile Chrome depending on swatch image size (bigcommerce#1793)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-143 Improper heading hierarchy on PLPs (bigcommerce#1779)

* fix(storefront): BCTHEME-161 ARIA attributes on Write Review modal need valid values (bigcommerce#1790)

* feat(storefront): BCTHEME-122 Add labels to swatches (bigcommerce#1761)

* fix(storefront): BCTHEME-67 Cart icon quantity should have appropriate link text (bigcommerce#1765)

* feature(storefront): BCTHEME-130 Carousel links should have discernible text (bigcommerce#1789)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-135 Missing tooltip for close button on change modal (bigcommerce#1773)

* Eslint fix

* fix(storefront):fix product Images don't change on click in IE11 (bigcommerce#1748)

* fix(storefront):Product Images don't change on click in IE11

* fix eslint errors

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-194 Review link in quick modal focused twice (bigcommerce#1797)

* Releasing 4.10.0-rc.1

* fix(storefront): BCTHEME-211 Cross icon on close button missalignment

* BCTHEME-191 Incorrect styles for focused buttons in grid card product item

* BCTHEME-196 Create unified focus styling in Cornerstone

* Releasing 4.10.0-rc.2

* fix(storefront): BCTHEME-230 Quick search query param needs to be fixed while navigating to search page

* fix(storefront): STRF-8599 Drop Jquery: Replaced event's current target to the element passed from utils(on hook)

* Releasing 4.10.0-rc.3

* fix(storefront): STRF-8607 Unified browsers list that we support

* fix(storefront): BCTHEME-265 Return heading to product card

* Releasing 4.10.0-rc.4

* Fixed quick search data attribute accroding to external hook api requirement

* Releasing 4.10.0-rc.5

* Fixed slick issue with cloning slides

* Releasing 4.10.0-rc.6

* Fix

* Releasing 4.10.0-rc.7

* Refactor GitHub action for Bundle Test (bigcommerce#1852)

Making a few improvements to the GitHub action which does a test bundle.

* Better docs/comments
* Better name
* Support "master" or "main" branch as new forks will use `main`
  * https://www.zdnet.com/article/github-to-replace-master-with-main-starting-next-month/
  * https://github.com/github/renaming
* Add both a ruby gem cache as well as an npm cache to speed things up (CLI install is most of the time spent currently)

* Update Test Badge in README.md

* Upload bundled .zip file on PRs for easy testing

* Releasing 4.10.0

* Cornerstone 4.10 changelog update

* fix(storefront): BCTHEME-171 State of search link not announced (bigcommerce#1798)

* fix(storefront): BCTHEME-198 Face accessibility standards with social links on PDP's page (bigcommerce#1809)

* fix(storefront): BCTHEME-215 Delete item button in cart cut off from right side when in focus (bigcommerce#1823)

* fix(storefront): BCTHEME-169 Subscription notification not announced (bigcommerce#1813)

* feat(storefront)bctheme-203: add sufficient contrast on checkboxes within faceted search (bigcommerce#1815)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-167 Focus not visible on logo element (bigcommerce#1800)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):BCTHEME-168: addcontrast for email address input according to AA standard (bigcommerce#1804)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):BCTHEME-174 add contrast on product ratings in Quick View (bigcommerce#1799)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):bctheme-173: add color for carousel arrows AA standard (bigcommerce#1814)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront)bctheme-220: add sufficient contrast to button border  color (bigcommerce#1817)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-229 Product carousel with related products - arrows not working (bigcommerce#1828)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME170: fix empty cart notification (bigcommerce#1846)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(cornerstone):BCTHEME-201: add expanded/collapsed state on add-info button (bigcommerce#1844)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)bctheme-223: fix voiceover focus not sync in faceted search (bigcommerce#1826)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront)BCTHEME75: add keyboard focus on write-a-review modal (bigcommerce#1835)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)bctheme-225:fix filter top outline on focus (bigcommerce#1829)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME-224: change role for sort by select (bigcommerce#1837)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront):bctheme-212 fix rating icons focus border (bigcommerce#1819)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME-216: fix outline styles for breadcrumbs on focus (bigcommerce#1824)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Fixed merge conflict

* feat(content): MERC-7162 Add header bottom global region

* Removed broken import from tools.scss file

* BCTHEME-213 Add Info and Add Coupon forms on Cart Page tabbable when hidden (bigcommerce#1820)

* Releasing 4.11.0-rc.1

* Update GitHub Action to use Node 12

Node 12 is now supported for Stencil CLI, so we'll use it for this action going forward.

* Add examples of useful GitHub Actions for theme development

* Releasing 4.11.0

* fix(payments): INT-3211 Change width size for apple pay button

* Update Changelog

* feat(storefront): STRF-8630 update cornerstone to be compatible with handlebars v4

* fix(storefront): BCTHEME-197 Logo focus of voice over has wrong (100% of the screen) width (bigcommerce#1831)

* fix(storefront): BCTHEME-222 Rating and Other filter sections are not accessible by keyboard (bigcommerce#1838)

* BCTHEME-210 Carousel hidden when one or more of its images not found (bigcommerce#1816)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-214 Wishlist first option has no bottom outline when in focus (bigcommerce#1825)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-217 Product link has incorrect voice over focus on Cart Page (bigcommerce#1830)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-172 Card content truncated on zooming browser to 400% (bigcommerce#1803)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-185 Sort By dropdowns need visual focus border (bigcommerce#1833)

* BCTHEME-188 Product cards should link to products (bigcommerce#1842)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-184 Options on change modal need focus border (bigcommerce#1839)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-199 Zooming and scaling must not be disabled (bigcommerce#1843)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-202 Notification of number of products not announced (bigcommerce#1845)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-190 Content should not scroll in two directions when zoomed (bigcommerce#1853)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront)BCTHEME-205: add filter reset announcement (bigcommerce#1858)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront) BCTHEME-206: add announcement fot filtered result on Shop-by-price (bigcommerce#1854)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront)BCTHEME-164: fix image in modal for IE11 (bigcommerce#1840)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-279 fix logo displaying (bigcommerce#1865)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront):add to cart notification (bigcommerce#1860)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-44 Cornerstone quick view (bigcommerce#1857)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-277 Certain Special Characters not rendering under Wishlists (bigcommerce#1873)

* fix(storefront): BCTHEME-219 Social icons not clickable in modal after reopening (bigcommerce#1874)

* fix(storefront): BCTHEME-282 Fix aria-labels for collapsibleFactory elements (bigcommerce#1868)

* BCTHEME-269 Remove layout shifts to improve CLS indicator from Lighthouse performance report (bigcommerce#1869)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-233 Cornerstone - Unable to Compare Products from Recently Viewed Items (bigcommerce#1877)

* feat(storefront): BCTHEME-290 add aria labelwith price for product list item (bigcommerce#1878)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* BCTHEME-209 Search result not notified by screen reader (bigcommerce#1867)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-289 Add aria label with price to Product Grid Item (bigcommerce#1875)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-268 Update carousel images to improve LCP indicator from Lighthouse performance report (bigcommerce#1876)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-187 improve localization and add default and fallback messages (bigcommerce#1850)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-297 Cornerstone 4.11.0 - Product Image Carousel Becomes Unresponsive on Product Page (bigcommerce#1879)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Resolved issues after merging PRs for 4.12 release

* Releasing 4.12.0-rc.1

* Reduce lodash usage in compare-products.js and image-gallery.js

* Releasing 4.12.0-rc.2

* Releasing 4.12.0-rc.3

* Releasing 4.12.0-rc.4

* Upload bundle analysis as part of github action

* feat(search): ES-1590 display error message if search fails

* feat: (STRF-8747) add new stencil config files to .gitignore

* Releasing 4.12.0

* Revert "Releasing 4.12.0"

* feat(storefront): BCTHEME-299 update  changelog for release 4.12

* Releasing 4.12.0

* Updated CHANGELOG.md before 4.12 release

* Reverting cornerstone version to 4.12-rc.4

* Releasing 4.12.0

* Reverting 4.12 changes

* Releasing 4.12.0

* Reverted 4.12 release commit and updated package.json versions

* Releasing 4.12.0

* Revert fix(storefront): BCTHEME-219 Social icons not clickable in modal

* Don't load social icons in quick view

* Bump stencil-utils

* fix(storefront): BCTHEME-305 Price Lists - Price in the cart is not updated when changing currency on mobile

* fix(storefront): BCTHEME-314 ccount >Payment Methods throws Server Error when using Cornerstone theme (bigcommerce#1898)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-315 Write a Review modal cause TypeError (bigcommerce#1899)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Releasing 4.12.1

* feat(payments): PAYPAL-712 Checkout page - Smart Payment Button styli… (bigcommerce#1866)

feat(payments): PAYPAL-712 Checkout page - Smart Payment Button styling (Cornerstone)

* feat(storefront): BCTHEME-116 move tax field after grand total when tax inclusive (bigcommerce#1903)

* fix(storefront): BCTHEME-105 Cornerstone - Body text size above 14px is cut off on cart shipping dropdowns (bigcommerce#1881)

* feat(storefront): BCTHEME-69 Add tooltips for carousel bullets (buttons) (bigcommerce#1889)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-319 Write a review modal extra executions (bigcommerce#1902) (bigcommerce#1902)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-232 Faceted search filters are hidden from screen readers (bigcommerce#1897)

* fix(storefront): BCTHEME-292 Social icon tooltip displaying should be fixed (bigcommerce#1907)

* BCTHEME-293 Product list item Quick view button is not tabbable (bigcommerce#1900) (bigcommerce#1900)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-273 fix contrast ratio for Skip to Main Content element (bigcommerce#1880)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* feat(storefront): BCTHEME-275 add upsell banner contrast (bigcommerce#1891)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-274 fix contranst ratio for brand name (bigcommerce#1882)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-288 Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled (bigcommerce#1883)

* fix(storefront): BCTHEME-308 HTML Entity displayed as is via system/error message on a Storefront (bigcommerce#1888)

* STRF-8769 Moved zoomSize and productSize to the upper level, cause product.js is not availabe on the Quick View (bigcommerce#1884)

* Bump versions of Ruby (bigcommerce#1905)

To fix issue bigcommerce#1904

* Changelog update

* fix(storefront): BCTHEME-104 Selecting product options doesn't update image on PDP in Internet Explorer (bigcommerce#1913)

* fix(storefront): BCTHEME-11 hide product options that are out of stock on cart (bigcommerce#1911)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-301 Header content placed out of the header block on mobile (bigcommerce#1908) (bigcommerce#1908)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-85 “Sort by” dropdown selection not reflected on search results page for News and Information tab (bigcommerce#1910) (bigcommerce#1910)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-86 Cornerstone - Text hover color does not change when Dropdown menu display mode is set to Alternative (bigcommerce#1918) (bigcommerce#1918)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* fix(storefront): BCTHEME-321 fix social icon tooltip overlaying (bigcommerce#1914)

Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>

* Resolving eslint error after merging

* fix(storefront): BCTHEME-30 fix misaligned tooltip for required product option (bigcommerce#1915)

Co-authored-by: yurytut1993 <66325265+yurytut1993@users.noreply.github.com>

* fix(storefront): BCTHEME-87 Product images squashed in Category view in AMP (bigcommerce#1921) (bigcommerce#1921)

* fix(storefront): BCTHEME-313 Parse HTML entities in jsContext (bigcommerce#1917)

* Added Changelog item for BCTHEME-313

* Releasing 5.0.0-rc.1

* feat(payments): PAYPAL-823 Add new banner on the cart page (bigcommerce#1901)

* Releasing 5.0.0-rc.2

* Releasing 5.0.0

---------

Co-authored-by: Matthew Coy <matt.coy@arcticleaf.io>
Co-authored-by: Yurii Zusik <yurii.zusik@bigcommerce.com>
Co-authored-by: Tymur Biedukhin <tymur.biedukhin@bigcommerce.com>
Co-authored-by: Andrii Fetisov <andrii.fetisov@bigcommerce.com>
Co-authored-by: Jairo Panduro <jairo.panduro@bigcommerce.com>
Co-authored-by: Juned Kazi <junedkazi@users.noreply.github.com>
Co-authored-by: Alex Saiannyi <67792608+bc-alexsaiannyi@users.noreply.github.com>
Co-authored-by: BC-tymurbiedukhin <66319629+BC-tymurbiedukhin@users.noreply.github.com>
Co-authored-by: yurytut1993 <66325265+yurytut1993@users.noreply.github.com>
Co-authored-by: Nathan Booker <bookernath@users.noreply.github.com>
Co-authored-by: Erik Christensen <erik.christensen@bigcommerce.com>
Co-authored-by: Nathan Booker <nathan.booker@bigcommerce.com>
Co-authored-by: Marco Loyo <marco.loyo@bigcommerce.com>
Co-authored-by: Pascal Zajac <pascalzajac@hotmail.com>
Co-authored-by: sacr3dc0w <mshettles@gmail.com>
Co-authored-by: alex.saiannyi <alexander.saiannyi@bigcommerce.com>
Co-authored-by: Kevin Wang <kwang30@gmail.com>
Co-authored-by: MaxGenash <max.henash@bigcommerce.com>
Co-authored-by: David Huynh <david.huynh@bigcommerce.com>
Co-authored-by: Andrii Fetisov <54856617+bc-fetisov@users.noreply.github.com>
Co-authored-by: jairo-bc <68893868+jairo-bc@users.noreply.github.com>
Co-authored-by: Andrew A. Barber <hello@andrewbarber.me>
Co-authored-by: Brian Davenport <bdav87@gmail.com>
Co-authored-by: Olga Lashkul <32959076+helga1507@users.noreply.github.com>
  • Loading branch information
25 people authored Sep 16, 2023
1 parent a2db6bd commit a6bb38c
Show file tree
Hide file tree
Showing 58 changed files with 1,163 additions and 622 deletions.
18 changes: 16 additions & 2 deletions .github/workflows/pull_request_review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,25 @@ jobs:

strategy:
matrix:
node: [18.x]
node: [12.x]

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v2

- name: Ruby Gem cache
uses: actions/cache@v2.1.3
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-gems-
- name: Setup Ruby 2.7
uses: ruby/setup-ruby@v1.51.1
with:
ruby-version: 2.7
- run: bundle install

- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
Expand Down
26 changes: 26 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,32 @@

## Draft

## 5.0.0 (12-14-2020)
- Parse HTML entities in jsContext. [#1917](https://github.com/bigcommerce/cornerstone/pull/1917)
- Product images squashed in Category view in AMP. [#1921](https://github.com/bigcommerce/cornerstone/pull/1921)
- Fixed misaligned tooltip for required product option. [#1915](https://github.com/bigcommerce/cornerstone/pull/1915)
- Fixed tooltip overlaying by facebook button. [#1914](https://github.com/bigcommerce/cornerstone/pull/1914)
- Cornerstone - Text hover color does not change when Dropdown menu display mode is set to 'Alternative'. [#1918](https://github.com/bigcommerce/cornerstone/pull/1918)
- “Sort by” dropdown selection not reflected on search results page for News and Information tab. [#1910](https://github.com/bigcommerce/cornerstone/pull/1910)
- Header content placed out of the header block on mobile. [#1908](https://github.com/bigcommerce/cornerstone/pull/1908)
- Fixed an issue with dispaying options that are out of stock for product on Cart. [#1911](https://github.com/bigcommerce/cornerstone/pull/1911)
- Selecting product options doesn't update image on PDP in Internet Explorer. [#1913](https://github.com/bigcommerce/cornerstone/pull/1913)
- HTML Entity displayed as is via system/error message on a Storefront. [#1888](https://github.com/bigcommerce/cornerstone/pull/1888)
- Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled. [#1883](https://github.com/bigcommerce/cornerstone/pull/1883)
- Fixed text contrast for brand name on Cart page. [#1882](https://github.com/bigcommerce/cornerstone/pull/1882)
- Add sufficient contrast for Upsell Banners in Cornerstone Theme according to AA Standard. [#1891](https://github.com/bigcommerce/cornerstone/pull/1891)
- Add appropriate text contrast for "Skip to Main Content". [#1880](https://github.com/bigcommerce/cornerstone/pull/1880)
- Product list item Quick view button is not tabbable. [#1900](https://github.com/bigcommerce/cornerstone/pull/1900)
- Social icon tooltip displaying should be fixed. [1907](https://github.com/bigcommerce/cornerstone/pull/1907)
- Faceted search filters are hidden from screen readers. [#1897](https://github.com/bigcommerce/cornerstone/pull/1897)
- Write a review modal extra executions. [#1902](https://github.com/bigcommerce/cornerstone/pull/1902)
- Add tooltips for carousel bullets (buttons). [#1889](https://github.com/bigcommerce/cornerstone/pull/1889)
- Cornerstone - Body text size above 14px is cut off on cart shipping dropdowns. [#1881](https://github.com/bigcommerce/cornerstone/pull/1881)
- Move Tax Field under Grand Total on Cart when Tax inclusive. [#1903](https://github.com/bigcommerce/cornerstone/pull/1903)
- Added styling config for the PayPal SPB on checkout page [#1866](https://github.com/bigcommerce/cornerstone/pull/1866)
- Moved zoomSize and productSize to the upper level, cause product.js is not availabe on the Quick View [#1884](https://github.com/bigcommerce/cornerstone/pull/1884)
- Added new region on the cart page [#1901](https://github.com/bigcommerce/cornerstone/pull/1901)

## 4.12.1 (11-10-2020)
- Write a Review modal cause TypeError. [#1899](https://github.com/bigcommerce/cornerstone/pull/1899)
- Account >Payment Methods throws Server Error when using Cornerstone theme [#1898](https://github.com/bigcommerce/cornerstone/pull/1898)
Expand Down
1 change: 1 addition & 0 deletions assets/js/test-unit/theme/common/collapsible.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ describe('Collapsible', () => {

it('should open if it is closed', () => {
collapsible.$target.removeClass('is-open');
collapsible.$target.hide();
collapsible.$toggle.trigger(CollapsibleEvents.click);

expect(collapsible.open).toHaveBeenCalled();
Expand Down
38 changes: 25 additions & 13 deletions assets/js/theme/cart.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
import PageManager from './page-manager';
import _ from 'lodash';
import { bind, debounce } from 'lodash';
import giftCertCheck from './common/gift-certificate-validator';
import utils from '@bigcommerce/stencil-utils';
import ShippingEstimator from './cart/shipping-estimator';
import { defaultModal, modalTypes } from './global/modal';
import swal from './global/sweet-alert';
import CartItemDetails from './common/cart-item-details';

export default class Cart extends PageManager {
onReady() {
this.$modal = null;
this.$cartContent = $('[data-cart-content]');
this.$cartMessages = $('[data-cart-status]');
this.$cartTotals = $('[data-cart-totals]');
Expand Down Expand Up @@ -125,30 +127,40 @@ export default class Cart extends PageManager {
});
}

cartEditOptions(itemId) {
cartEditOptions(itemId, productId) {
const context = { productForChangeId: productId, ...this.context };
const modal = defaultModal();

if (this.$modal === null) {
this.$modal = $('#modal');
}

const options = {
template: 'cart/modals/configure-product',
};

modal.open();
this.$modal.find('.modal-content').addClass('hide-content');

utils.api.productAttributes.configureInCart(itemId, options, (err, response) => {
modal.updateContent(response.content);
const $productOptionsContainer = $('[data-product-attributes-wrapper]', this.$modal);
const modalBodyReservedHeight = $productOptionsContainer.outerHeight();
$productOptionsContainer.css('height', modalBodyReservedHeight);

this.productDetails = new CartItemDetails(this.$modal, context);

this.bindGiftWrappingForm();

modal.setupFocusableElements(modalTypes.CART_CHANGE_PRODUCT);
});

utils.hooks.on('product-option-change', (event, currentTarget) => {
const $changedOption = $(currentTarget);
const $form = $changedOption.parents('form');
const $form = $(currentTarget).find('form');
const $submit = $('input.button', $form);
const $messageBox = $('.alertMessageBox');
const item = $('[name="item_id"]', $form).attr('value');

utils.api.productAttributes.optionChange(item, $form.serialize(), (err, result) => {
utils.api.productAttributes.optionChange(productId, $form.serialize(), (err, result) => {
const data = result.data || {};

if (err) {
Expand Down Expand Up @@ -213,9 +225,9 @@ export default class Cart extends PageManager {

bindCartEvents() {
const debounceTimeout = 400;
const cartUpdate = _.bind(_.debounce(this.cartUpdate, debounceTimeout), this);
const cartUpdateQtyTextChange = _.bind(_.debounce(this.cartUpdateQtyTextChange, debounceTimeout), this);
const cartRemoveItem = _.bind(_.debounce(this.cartRemoveItem, debounceTimeout), this);
const cartUpdate = bind(debounce(this.cartUpdate, debounceTimeout), this);
const cartUpdateQtyTextChange = bind(debounce(this.cartUpdateQtyTextChange, debounceTimeout), this);
const cartRemoveItem = bind(debounce(this.cartRemoveItem, debounceTimeout), this);
let preVal;

// cart update
Expand Down Expand Up @@ -257,10 +269,10 @@ export default class Cart extends PageManager {

$('[data-item-edit]', this.$cartContent).on('click', event => {
const itemId = $(event.currentTarget).data('itemEdit');

const productId = $(event.currentTarget).data('productId');
event.preventDefault();
// edit item in cart
this.cartEditOptions(itemId);
this.cartEditOptions(itemId, productId);
});
}

Expand Down Expand Up @@ -304,7 +316,7 @@ export default class Cart extends PageManager {
this.refreshContent();
} else {
swal.fire({
text: response.data.errors.join('\n'),
html: response.data.errors.join('\n'),
icon: 'error',
});
}
Expand Down Expand Up @@ -348,7 +360,7 @@ export default class Cart extends PageManager {
this.refreshContent();
} else {
swal.fire({
text: resp.data.errors.join('\n'),
html: resp.data.errors.join('\n'),
icon: 'error',
});
}
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/category.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { hooks } from '@bigcommerce/stencil-utils';
import CatalogPage from './catalog';
import compareProducts from './global/compare-products';
import FacetedSearch from './common/faceted-search';
import { showCategoryModal } from './global/modal';
import { createTranslationDictionary } from '../theme/common/utils/translations-utils';
import { showCategoryModal } from './global/modal';

export default class Category extends CatalogPage {
constructor(context) {
Expand Down
136 changes: 0 additions & 136 deletions assets/js/theme/common/carousel.js

This file was deleted.

71 changes: 71 additions & 0 deletions assets/js/theme/common/carousel/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
import 'slick-carousel';

import {
dotsSetup,
setTabindexes,
arrowAriaLabling,
heroCarouselSetup,
getRealSlidesQuantityAndCurrentSlide,
} from './utils';

const onCarouselChange = (event, carousel) => {
const {
options: { prevArrow, nextArrow },
currentSlide,
slideCount,
$dots,
$slider,
breakpointSettings,
activeBreakpoint,
} = carousel;

const { actualSlideCount, actualSlide } = getRealSlidesQuantityAndCurrentSlide(
breakpointSettings,
activeBreakpoint,
currentSlide,
slideCount,
$slider.data('slick').slidesToScroll,
);

const $prevArrow = $slider.find(prevArrow);
const $nextArrow = $slider.find(nextArrow);

dotsSetup($dots, actualSlide, actualSlideCount, $slider.data('dots-labels'));
setTabindexes($slider.find('.slick-slide'), $prevArrow, $nextArrow, actualSlide, actualSlideCount);
arrowAriaLabling($prevArrow, $nextArrow, actualSlide, actualSlideCount);
};

export default function () {
const $carouselCollection = $('[data-slick]');

if ($carouselCollection.length === 0) return;

$carouselCollection.each((index, carousel) => {
// getting element using find to pass jest test
const $carousel = $(document).find(carousel);

if ($carousel.hasClass('productView-thumbnails')) {
$carousel.slick();
return;
}

$carousel.on('init', onCarouselChange);
$carousel.on('afterChange', onCarouselChange);

const isMultipleSlides = $carousel.children().length > 1;
const customPaging = isMultipleSlides
? () => (
'<button type="button"></button>'
)
: () => {};

$carousel.slick({
accessibility: false,
arrows: isMultipleSlides,
customPaging,
dots: isMultipleSlides,
});
});

heroCarouselSetup($carouselCollection.filter('.heroCarousel'));
}
Loading

0 comments on commit a6bb38c

Please sign in to comment.