Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): support bulk minting with pointers #121

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

kevzzsk
Copy link
Collaborator

@kevzzsk kevzzsk commented Jun 24, 2024

What this PR does / why we need it:

Deprecate Inscriber class and use InscriberV2 to support bulk minting as well.
Created bulkMintFromCollection function to build necessary params for InscriberV2

also to note that, on the scripting side due to BIP-0062 bitcoinjs will try to convert scripts to its smallest possible push operation so OP_PUSHBYTES_1 01 is the same as OP_PUSHNUM_1. This has also been supported by ord PR

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • Read your code changes at least once
  • No console errors
  • Unit tests*
  • Added e2e tests*

@kevzzsk kevzzsk self-assigned this Jun 24, 2024
@Nanosync Nanosync merged commit d1c706c into sadoprotocol:main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants