Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(indexer): fix bug on spent outputs reorg logic #99

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix(indexer): fix bug on spent outputs reorg logic #99

merged 3 commits into from
Nov 11, 2024

Conversation

dcorral
Copy link
Contributor

@dcorral dcorral commented Oct 24, 2024 •
edited
Loading

This PR fixes the spent outputs reorg logic.

  • Since the spending of outputs updated the txBlockHeight, on reorg, the spent outputs where deleted instead of marking them as spendable again.
  • Also the PR simplifies the reorg logic since the previous logic was unnecessary.

@dcorral dcorral marked this pull request as draft October 28, 2024 14:05
@dcorral dcorral force-pushed the dcorral/fix-spent-update-on-reorg branch from d033b5b to 30bfef8 Compare November 3, 2024 20:14
@dcorral dcorral marked this pull request as ready for review November 4, 2024 12:03
danadi7
danadi7 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@danadi7 danadi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danadi7 danadi7 merged commit 398a1ab into main Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danadi7 danadi7 danadi7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcorral @danadi7