[EXPERIMENTAL] expose testdriver + webdriver bidi #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Feb 16, 2024
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
3 times, most recently
from
b7e7259
to
ca69363
Compare
OrKoN
reviewed
Feb 16, 2024
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
2 times, most recently
from
c59430c
to
465c289
Compare
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
from
465c289
to
8881d6d
Compare
OrKoN
reviewed
Feb 16, 2024
OrKoN
reviewed
Feb 16, 2024
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
from
c67fdfd
to
4709dc3
Compare
OrKoN
reviewed
Feb 16, 2024
| method = self.webdriver.execute_async_script if asynchronous else self.webdriver.execute_script | ||
| return method(script, args=args) | ||
|
|
||
| async def async_execute_script(self, script, context, args=None): |
There was a problem hiding this comment.
I am thinking if async_execute_script is a good name since the execute_script can also be "async" by setting asynchronous to True. Perhaps we could find a better name but not blocking.
There was a problem hiding this comment.
Do you have a good idea for the name?
There was a problem hiding this comment.
Not really, I think it's probably the best name possible and kind of appears to be common in python codebases to prefix async def with async_
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
Co-authored-by: Alex Rudenko <OrKoN@users.noreply.github.com>
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
from
ca23586
to
4e9a4b5
Compare
|
Closing in favor of web-platform-tests#44649. |
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
from
fc3e7c3
to
2b70181
Compare
sadym-chromium
force-pushed
the
sadym/testdriver-bidi
branch
from
29a2840
to
2757eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.