feat: correctly handle dep:<crate_name> features in completion

saecki · Jun 29, 2024 · c2c6b3e · c2c6b3e
1 parent ada726a
commit c2c6b3e
Showing 1 changed file with 14 additions and 1 deletion.
diff --git a/lua/crates/completion/common.lua b/lua/crates/completion/common.lua
@@ -109,16 +109,29 @@ local function complete_features(crate, cf, versions)
             goto continue
         end
 
+        -- handle `dep:<crate_name>` features
+        local insert_text = nil
+        if f.dep then
+            local parent_name = string.sub(f.name, 5)
+            -- don't suggest duplicates         or already enabled features
+            if newest.features.map[parent_name] or crate:get_feat(parent_name) then
+                goto continue
+            end
+
+            insert_text = parent_name
+        end
+
         ---@type CompletionItem
         local r = {
             label = f.name,
             kind = CompletionItemKind.VALUE,
             sortText = f.name,
             detail = table.concat(f.members, "\n"),
+            insertText = insert_text,
         }
         if state.cfg.completion.insert_closing_quote then
             if not cf.quote.e then
-                r.insertText = f.name .. cf.quote.s
+                r.insertText = (insert_text or f.name) .. cf.quote.s
             end
         end
         if state.cfg.completion.cmp.use_custom_kind then