fix: don't show possibly misleading info or diagnostics for local dep…

…encencies

Since we currently can't resolve workspace, path, or git depencencies
there is no guarantee that any crate with the same name we would fetch
from crates.io is in any way related to local dependency.

lua/crates/core.lua

@@ -96,11 +96,17 @@ function M.update(buf, reload)
    ui.clear(buf)
    ui.display_diagnostics(buf, diagnostics)
    for k, c in pairs(crate_cache) do
-      local crate = state.api_cache[c:package()]
-      local versions = crate and crate.versions
 
-      if not reload and crate then
-         local info, c_diagnostics = diagnostic.process_api_crate(c, crate)
+
+      if c.dep_kind ~= "registry" then
+         return
+      end
+
+      local api_crate = state.api_cache[c:package()]
+      local versions = api_crate and api_crate.versions
+
+      if not reload and api_crate then
+         local info, c_diagnostics = diagnostic.process_api_crate(c, api_crate)
          cache.info[k] = info
          vim.list_extend(cache.diagnostics, c_diagnostics)
 

lua/crates/diagnostic.lua

@@ -231,29 +231,19 @@ function M.process_api_crate(crate, api_crate)
    }
    local diagnostics = {}
 
-   if crate.workspace then
-      info.dep_kind = "workspace"
-   elseif crate.path then
-      info.dep_kind = "path"
-   elseif crate.git then
-      info.dep_kind = "git"
-   else
-      info.dep_kind = "registry"
-   end
-
-   if api_crate then
-      if api_crate.name ~= crate:package() then
-         table.insert(diagnostics, crate_diagnostic(
-         crate,
-         "crate_name_case",
-         vim.diagnostic.severity.ERROR,
-         nil,
-         { crate = crate, crate_name = api_crate.name }))
+   if crate.dep_kind == "registry" then
+      if api_crate then
+         if api_crate.name ~= crate:package() then
+            table.insert(diagnostics, crate_diagnostic(
+            crate,
+            "crate_name_case",
+            vim.diagnostic.severity.ERROR,
+            nil,
+            { crate = crate, crate_name = api_crate.name }))
 
+         end
       end
-   end
 
-   if info.dep_kind == "registry" then
       if newest then
          if semver.matches_requirements(newest.parsed, crate:vers_reqs()) then
 

lua/crates/toml.lua

@@ -140,6 +140,14 @@ local M = {Section = {}, Crate = {Vers = {}, Registry = {}, Path = {}, Git = {},
 
 
 
+
+
+
+
+
+
+
+
 
 
 
@@ -197,6 +205,16 @@ function Crate.new(obj)
       obj.opt.enabled = obj.opt.text ~= "false"
    end
 
+   if obj.workspace then
+      obj.dep_kind = "workspace"
+   elseif obj.path then
+      obj.dep_kind = "path"
+   elseif obj.git then
+      obj.dep_kind = "git"
+   else
+      obj.dep_kind = "registry"
+   end
+
    return setmetatable(obj, { __index = Crate })
 end
 

lua/crates/types.lua

@@ -124,14 +124,6 @@ local M = {CrateInfo = {}, Diagnostic = {}, Crate = {}, Version = {}, Features =
 
 
 
-
-
-
-
-
-
-
-
 
 
 

lua/crates/ui.lua

@@ -67,11 +67,7 @@ function M.display_crate_info(buf, info, diagnostics)
       })
    end
 
-   if info.dep_kind == "path" then
-
-   elseif info.dep_kind == "git" then
-
-   elseif info.dep_kind == "registry" and not (info.vers_match or info.vers_upgrade) then
+   if not (info.vers_match or info.vers_upgrade) then
       table.insert(virt_text, {
          state.cfg.text.error,
          state.cfg.highlight.error,

teal/crates/core.tl

@@ -96,11 +96,17 @@ function M.update(buf: integer|nil, reload: boolean)
     ui.clear(buf)
     ui.display_diagnostics(buf, diagnostics)
     for k,c in pairs(crate_cache) do
-        local crate = state.api_cache[c:package()]
-        local versions = crate and crate.versions
+        -- Don't try to fetch info from crates.io if it's a local or git crate
+        -- TODO: Once there is workspace support, resolve the crate
+        if c.dep_kind ~= "registry" then
+            return
+        end
+
+        local api_crate = state.api_cache[c:package()]
+        local versions = api_crate and api_crate.versions
 
-        if not reload and crate then
-            local info, c_diagnostics = diagnostic.process_api_crate(c, crate)
+        if not reload and api_crate then
+            local info, c_diagnostics = diagnostic.process_api_crate(c, api_crate)
             cache.info[k] = info
             vim.list_extend(cache.diagnostics, c_diagnostics)
 

teal/crates/diagnostic.tl

@@ -231,29 +231,19 @@ function M.process_api_crate(crate: toml.Crate, api_crate: Crate): CrateInfo, {D
     }
     local diagnostics = {}
 
-    if crate.workspace then
-        info.dep_kind = "workspace"
-    elseif crate.path then
-        info.dep_kind = "path"
-    elseif crate.git then
-        info.dep_kind = "git"
-    else
-        info.dep_kind = "registry"
-    end
-
-    if api_crate then
-        if api_crate.name ~= crate:package() then
-            table.insert(diagnostics, crate_diagnostic(
-                crate,
-                "crate_name_case",
-                vim.diagnostic.severity.ERROR,
-                nil,
-                { crate = crate, crate_name = api_crate.name }
-            ))
+    if crate.dep_kind == "registry" then
+        if api_crate then
+            if api_crate.name ~= crate:package() then
+                table.insert(diagnostics, crate_diagnostic(
+                    crate,
+                    "crate_name_case",
+                    vim.diagnostic.severity.ERROR,
+                    nil,
+                    { crate = crate, crate_name = api_crate.name }
+                ))
+            end
         end
-    end
 
-    if info.dep_kind == "registry" then
         if  newest then
             if semver.matches_requirements(newest.parsed, crate:vers_reqs()) then
                 -- version matches, no upgrade available

teal/crates/toml.tl

@@ -36,6 +36,7 @@ local record M
         def: Def
         feat: Feat
         section: Section
+        dep_kind: DepKind
 
         enum Syntax
             "plain"
@@ -135,6 +136,13 @@ local record M
         end
     end
 
+    enum DepKind
+        "registry"
+        "path"
+        "git"
+        "workspace"
+    end
+
     record Feature
         name: string
         col: Range -- relative to to the start of the features text
@@ -197,6 +205,16 @@ function Crate.new(obj: Crate): Crate
         obj.opt.enabled = obj.opt.text ~= "false"
     end
 
+    if obj.workspace then
+        obj.dep_kind = "workspace"
+    elseif obj.path then
+        obj.dep_kind = "path"
+    elseif obj.git then
+        obj.dep_kind = "git"
+    else
+        obj.dep_kind = "registry"
+    end
+
     return setmetatable(obj, { __index = Crate })
 end
 

teal/crates/types.tl

@@ -6,7 +6,6 @@ local record M
         vers_update: Version
         vers_upgrade: Version
         match_kind: MatchKind
-        dep_kind: DepKind
     end
 
     enum MatchKind
@@ -16,13 +15,6 @@ local record M
         "nomatch"
     end
 
-    enum DepKind
-        "registry"
-        "path"
-        "git"
-        "workspace"
-    end
-
     record Diagnostic
         lnum: integer
         end_lnum: integer

teal/crates/ui.tl

@@ -67,11 +67,7 @@ function M.display_crate_info(buf: integer, info: CrateInfo, diagnostics: {Diagn
         })
     end
 
-    if info.dep_kind == "path" then
-        -- TODO: display relevant information
-    elseif info.dep_kind == "git" then
-        -- TODO: display relevant information
-    elseif info.dep_kind == "registry" and not (info.vers_match or info.vers_upgrade) then
+    if not (info.vers_match or info.vers_upgrade) then
         table.insert(virt_text, {
              state.cfg.text.error,
              state.cfg.highlight.error,